You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Thomas Neidhart (JIRA)" <ji...@apache.org> on 2013/05/05 15:20:15 UTC
[jira] [Issue Comment Deleted] (COLLECTIONS-453) findBugs Warnings:
several classes in package functors may expose their internal
representation
[ https://issues.apache.org/jira/browse/COLLECTIONS-453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Neidhart updated COLLECTIONS-453:
----------------------------------------
Comment: was deleted
(was: The remaining classes should use varargs arguments instead of arrays.
The constructor shall then copy the input arguments.)
> findBugs Warnings: several classes in package functors may expose their internal representation
> -----------------------------------------------------------------------------------------------
>
> Key: COLLECTIONS-453
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-453
> Project: Commons Collections
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Thomas Neidhart
> Fix For: 4.0
>
>
> Several classes (e.g. SwitchTransformer) take in their constructor an array as input which is not copied/cloned.
> Thus its internal representation may be changed externally.
> The corresponding factory methods *do* copy the input arguments thus we have two choices:
> * move the copy from the factory methods to the ctors
> * make the ctors private to prevent their use
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira