You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/11/28 09:38:45 UTC
[GitHub] [kafka] divijvaidya opened a new pull request, #12908: MINOR: Prevent NPE in SmokeTestDriver (fix flaky test)
divijvaidya opened a new pull request, #12908:
URL: https://github.com/apache/kafka/pull/12908
`SmokeTestDriverIntegrationTest.java` can be flaky because a NullPointerException prevents [the retry mechanism](https://github.com/apache/kafka/blob/trunk/streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java#L461) that is added to prevent flakiness for this test. This change, prevents the NullPointerException and hence, allows the test to retry itself.
Build during which NPE was observed: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12890/4/testReport/junit/org.apache.kafka.streams.integration/SmokeTestDriverIntegrationTest/Build___JDK_11_and_Scala_2_13___shouldWorkWithRebalance/?cloudbees-analytics-link=scm-reporting%2Ftests%2Ffailed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12908: MINOR: Prevent NPE in SmokeTestDriver (fix flaky test)
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12908:
URL: https://github.com/apache/kafka/pull/12908#issuecomment-1336108293
Failed with some `MemoryRecordsBuilderTest` tests. Re-run jenkins: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12908/4/
```
Build / JDK 8 and Scala 2.12 / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[4] magic=0, bufferOffset=0, compressionType=gzip
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[5] magic=1, bufferOffset=0, compressionType=gzip
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[10] magic=0, bufferOffset=0, compressionType=lz4
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[15] magic=1, bufferOffset=15, compressionType=none
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[19] magic=2, bufferOffset=15, compressionType=gzip
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[20] magic=0, bufferOffset=15, compressionType=snappy
Build / JDK 11 and Scala 2.13 / org.apache.kafka.common.record.MemoryRecordsBuilderTest.[22] magic=2, bufferOffset=15, compressionType=snappy
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lucasbru commented on a diff in pull request #12908: MINOR: Prevent NPE in SmokeTestDriver (fix flaky test)
Posted by GitBox <gi...@apache.org>.
lucasbru commented on code in PR #12908:
URL: https://github.com/apache/kafka/pull/12908#discussion_r1033809187
##########
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java:
##########
@@ -470,6 +461,18 @@ public static VerificationResult verify(final String kafka,
return verificationResult;
}
+ private static Map<String, Set<Number>> parseRecordsForEchoTopic(final Map<String, Map<String, LinkedList<ConsumerRecord<String, Number>>>> events) {
+ return events.containsKey("echo") ?
Review Comment:
nit: This is along expression, I'd prefer to write this with an if-construct, but I won't insist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon merged pull request #12908: MINOR: Prevent NPE in SmokeTestDriver (fix flaky test)
Posted by GitBox <gi...@apache.org>.
showuon merged PR #12908:
URL: https://github.com/apache/kafka/pull/12908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #12908: MINOR: Prevent NPE in SmokeTestDriver (fix flaky test)
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on PR #12908:
URL: https://github.com/apache/kafka/pull/12908#issuecomment-1330518989
@showuon please take a look when you get a chance!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on a diff in pull request #12908: MINOR: Prevent NPE in SmokeTestDriver (fix flaky test)
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on code in PR #12908:
URL: https://github.com/apache/kafka/pull/12908#discussion_r1033816997
##########
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java:
##########
@@ -470,6 +461,18 @@ public static VerificationResult verify(final String kafka,
return verificationResult;
}
+ private static Map<String, Set<Number>> parseRecordsForEchoTopic(final Map<String, Map<String, LinkedList<ConsumerRecord<String, Number>>>> events) {
+ return events.containsKey("echo") ?
Review Comment:
Thank you for your review!
This is fixed in latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #12908: MINOR: Prevent NPE in SmokeTestDriver (fix flaky test)
Posted by GitBox <gi...@apache.org>.
showuon commented on PR #12908:
URL: https://github.com/apache/kafka/pull/12908#issuecomment-1338657516
Failed tests are unrelated
```
Build / JDK 17 and Scala 2.13 / org.apache.kafka.common.network.SslVersionsTransportLayerTest.tlsServerProtocol = [TLSv1.2, TLSv1.3], tlsClientProtocol = [TLSv1.3]
Build / JDK 17 and Scala 2.13 / kafka.server.DynamicBrokerReconfigurationTest.testTrustStoreAlter(String).quorum=kraft
Build / JDK 17 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
Build / JDK 8 and Scala 2.12 / kafka.api.TransactionsExpirationTest.testTransactionAfterProducerIdExpires(String).quorum=zk
Build / JDK 8 and Scala 2.12 / kafka.server.RaftClusterSnapshotTest.testSnapshotsGenerated()
Build / JDK 11 and Scala 2.13 / kafka.admin.MetadataQuorumCommandTest.[1] Type=Raft-CoReside, Name=testDescribeQuorumReplicationSuccessful, MetadataVersion=3.4-IV0, Security=PLAINTEXT
Build / JDK 11 and Scala 2.13 / kafka.admin.MetadataQuorumCommandTest.[2] Type=Raft-Distributed, Name=testDescribeQuorumStatusSuccessful, MetadataVersion=3.4-IV0, Security=PLAINTEXT
Build / JDK 11 and Scala 2.13 / kafka.admin.MetadataQuorumCommandTest.[3] Type=Raft-CoReside, Name=testDescribeQuorumStatusSuccessful, MetadataVersion=3.4-IV0, Security=PLAINTEXT
Build / JDK 11 and Scala 2.13 / kafka.admin.MetadataQuorumCommandTest.[5] Type=Raft-CoReside, Name=testDescribeQuorumStatusSuccessful, MetadataVersion=3.4-IV0, Security=PLAINTEXT
Build / JDK 11 and Scala 2.13 / kafka.admin.ReassignPartitionsIntegrationTest.testHighWaterMarkAfterPartitionReassignment(String).quorum=kraft
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org