You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2023/05/25 21:17:25 UTC

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3428: Introduce new GC trash property, move duplicate methods to new class

dlmarion commented on code in PR #3428:
URL: https://github.com/apache/accumulo/pull/3428#discussion_r1206011159


##########
server/gc/src/test/java/org/apache/accumulo/gc/SimpleGarbageCollectorNewPropertyTest.java:
##########


Review Comment:
   By extending `SimpleGarbageCollectorTest` and overriding `createSystemConfig` to use the new `GC_USE_TRASH` property instead of the older `GC_TRASH_IGNORE` this test exercises all of the tests in the parent class using the new property and this one additional test in this class for the new property option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org