You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/14 08:53:56 UTC

[GitHub] [spark] cloud-fan commented on a diff in pull request #38648: [SPARK-41134][SQL] Improve error message of internal errors

cloud-fan commented on code in PR #38648:
URL: https://github.com/apache/spark/pull/38648#discussion_r1021221885


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala:
##########
@@ -494,7 +494,8 @@ object QueryExecution {
   private[sql] def toInternalError(msg: String, e: Throwable): Throwable = e match {
     case e @ (_: java.lang.NullPointerException | _: java.lang.AssertionError) =>
       SparkException.internalError(
-        msg + " Please, fill a bug report in, and provide the full stack trace.",
+        msg + " You hit a bug in Spark or the Spark plugins you use. Please, report this bug " +

Review Comment:
   Spark should be responsible for its dependencies, as it's not the users but Spark that decides which library to depend on. Spark plugins are users' choice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org