You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Ramya R (JIRA)" <ji...@apache.org> on 2009/01/20 06:48:59 UTC

[jira] Created: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Split TestCLI into HDFS, Mapred and Core tests
----------------------------------------------

                 Key: HADOOP-5081
                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
             Project: Hadoop Core
          Issue Type: Test
          Components: test
    Affects Versions: 0.20.0
            Reporter: Ramya R
            Priority: Minor
             Fix For: 0.20.0


At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharad Agarwal updated HADOOP-5081:
-----------------------------------

    Status: Patch Available  (was: Open)

> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 5081_v1.patch, 5081_v2.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharad Agarwal updated HADOOP-5081:
-----------------------------------

    Fix Version/s: 0.21.0
           Status: Patch Available  (was: Open)

> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 5081_v1.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharad Agarwal updated HADOOP-5081:
-----------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this.

> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 5081_v1.patch, 5081_v2.patch, 5081_v3.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharad Agarwal updated HADOOP-5081:
-----------------------------------

    Attachment: 5081_v2.patch

Incorporated review comments.

> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 5081_v1.patch, 5081_v2.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706156#action_12706156 ] 

Hudson commented on HADOOP-5081:
--------------------------------

Integrated in Hadoop-trunk #827 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/827/])
    . Split TestCLI into HDFS, Mapred and Core tests.


> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 5081_v1.patch, 5081_v2.patch, 5081_v3.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharad Agarwal updated HADOOP-5081:
-----------------------------------

    Attachment: 5081_v1.patch

This patch:
Splits the class TestCLI into TestCLI, TestHDFSCLI and TestMRCLI.
Also it splits the test files into testConf.xml, testHDFSConf.xml, testMRConf.xml

> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>         Attachments: 5081_v1.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharad Agarwal updated HADOOP-5081:
-----------------------------------

    Status: Open  (was: Patch Available)

> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 5081_v1.patch, 5081_v2.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharad Agarwal updated HADOOP-5081:
-----------------------------------

    Attachment: 5081_v3.patch

added license header in TestHDFSCLI and TestMRCLI

> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 5081_v1.patch, 5081_v2.patch, 5081_v3.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705961#action_12705961 ] 

Sharad Agarwal commented on HADOOP-5081:
----------------------------------------

test failures are unrelated.

> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 5081_v1.patch, 5081_v2.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705554#action_12705554 ] 

Jothi Padmanabhan commented on HADOOP-5081:
-------------------------------------------

Some minor comments

# CommandExecutor.execute should ideally return a Results object instead of returning the executor itself
# There are quite a few assert statements that basically are no-ops as the condition would always return as true
# Remove unused import in TestCLI.java
# Remove the comment "// Start up mini mr cluster" in TestCLI.setup

> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 5081_v1.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Jothi Padmanabhan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705933#action_12705933 ] 

Jothi Padmanabhan commented on HADOOP-5081:
-------------------------------------------

+1.

> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 5081_v1.patch, 5081_v2.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Sharad Agarwal (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sharad Agarwal reassigned HADOOP-5081:
--------------------------------------

    Assignee: Sharad Agarwal

> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5081) Split TestCLI into HDFS, Mapred and Core tests

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705941#action_12705941 ] 

Hadoop QA commented on HADOOP-5081:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12407145/5081_v2.patch
  against trunk revision 771525.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 664 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    -1 release audit.  The applied patch generated 475 release audit warnings (more than the trunk's current 472 warnings).

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/artifact/trunk/current/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/289/console

This message is automatically generated.

> Split TestCLI into HDFS, Mapred and Core tests
> ----------------------------------------------
>
>                 Key: HADOOP-5081
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5081
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.20.0
>            Reporter: Ramya R
>            Assignee: Sharad Agarwal
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: 5081_v1.patch, 5081_v2.patch
>
>
> At present, TestCLI contains command line tests for both hdfs and mapred. Going forward, this test has to be broken up into separate hdfs, mapred and core tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.