You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Konstantin Knauf (Jira)" <ji...@apache.org> on 2021/07/29 07:28:13 UTC
[jira] [Reopened] (FLINK-14810) It's weird that copy
julianDateFloor from DateTimeUtils and change the implementation
[ https://issues.apache.org/jira/browse/FLINK-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Knauf reopened FLINK-14810:
--------------------------------------
Re-opening in accordance with https://issues.apache.org/jira/browse/FLINK-23206.
> It's weird that copy julianDateFloor from DateTimeUtils and change the implementation
> -------------------------------------------------------------------------------------
>
> Key: FLINK-14810
> URL: https://issues.apache.org/jira/browse/FLINK-14810
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Planner
> Reporter: Zhenghua Gao
> Priority: Minor
> Labels: auto-closed
>
> In SqlDateTimeUtils we copied *julianToLocalDate* from DateTimeUtils and changed the implementation. It's weird to use an *entirely* *different* implementation to do the same thing.
> One possible improvement of the new one is support TimeUnitRange.QUARTER. But the logic to calculate year/month/day is totally different.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)