You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Lukasz Lenart (Jira)" <ji...@apache.org> on 2021/01/03 09:57:00 UTC
[jira] [Comment Edited] (WW-5000) Replace string literals with proper constants in @Inject

    [ https://issues.apache.org/jira/browse/WW-5000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257465#comment-17257465 ] 

Lukasz Lenart edited comment on WW-5000 at 1/3/21, 9:56 AM:
------------------------------------------------------------

Defined new constants:
{code}
    public static final String STRUTS_CHAINING_COPY_ERRORS = "struts.chaining.copyErrors";
    public static final String STRUTS_CHAINING_COPY_FIELD_ERRORS = "struts.chaining.copyFieldErrors";
    public static final String STRUTS_CHAINING_COPY_MESSAGES = "struts.chaining.copyMessages";
{code}

{{xwork.autoGrowCollectionLimit}} => {{struts.ognl.autoGrowthCollectionLimit}}

{{objectFactory.classloader}} => {{struts.objectFactory.classloader}}

{{logMissingProperties}} => {{struts.ognl.logMissingProperties}}


was (Author: lukaszlenart):
Defined new constants:
{code}
    public static final String STRUTS_CHAINING_COPY_ERRORS = "struts.chaining.copyErrors";
    public static final String STRUTS_CHAINING_COPY_FIELD_ERRORS = "struts.chaining.copyFieldErrors";
    public static final String STRUTS_CHAINING_COPY_MESSAGES = "struts.chaining.copyMessages";
{code}

{{xwork.autoGrowCollectionLimit}} => {{struts.ognl.autoGrowthCollectionLimit}}

{{objectFactory.classloader}} => {{struts.objectFactory.classloader}}

> Replace string literals with proper constants in @Inject
> --------------------------------------------------------
>
>                 Key: WW-5000
>                 URL: https://issues.apache.org/jira/browse/WW-5000
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.6
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In many places string literals are used instead of a proper reference to a constant.
> {noformat}
> @Inject(value = "struts.xwork.chaining.copyMessages", required = false)
> @Inject(value = "struts.xwork.chaining.copyFieldErrors", required = false)
> @Inject(value = "struts.xwork.chaining.copyErrors", required = false)
> @Inject(value = "struts.javatemplates.defaultTemplateType", required = false)
> @Inject(value = "struts.javatemplates.customThemes", required = false)
> @Inject(value = "struts.objectFactory.cdi.jndiKey", required = false)
> @Inject(value = "enableAopSupport", required = false)
> @Inject(value = "struts.oval.validateJPAAnnotations")
> @Inject(value = "xwork.autoGrowCollectionLimit", required = false)
> @Inject(value = "logMissingProperties", required = false)
> @Inject(value="objectFactory.classloader", required=false)
> @Inject(value="allowStaticMethodAccess", required=false)
> @Inject(value="applicationContextPath",required=false)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)