You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/24 08:43:56 UTC
[GitHub] [flink-kubernetes-operator] gaborgsomogyi opened a new pull request, #452: [FLINK-30187] Get operator log considering namespace
gaborgsomogyi opened a new pull request, #452:
URL: https://github.com/apache/flink-kubernetes-operator/pull/452
## What is the purpose of the change
Multi session job test is silently not checking the operator log for errors:
```
Checking for operator log errors...
error: You must provide one or more resources by argument or filename.
Example resource specifications include:
'-f rsrc.yaml'
'--filename=rsrc.json'
'<resource> <name>'
'<resource>'
No errors in log files.
```
The issue is that `test_multi_sessionjob.sh` changes the default namespace but the operator pod find functionality not considered namespace changes. In this PR I've fixed that.
## Brief change log
* Consider namespace when getting operator pod
* Fixed indentation couple of places
* Error check added in `get_jm_pod_name`
## Verifying this change
Existing e2e tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #452: [FLINK-30187] Get operator log considering namespace
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #452:
URL: https://github.com/apache/flink-kubernetes-operator/pull/452#issuecomment-1326175970
Seems like the fix works: https://github.com/apache/flink-kubernetes-operator/actions/runs/3539014809/jobs/5940447380#step:9:40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #452: [FLINK-30187] Get operator log considering namespace
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #452:
URL: https://github.com/apache/flink-kubernetes-operator/pull/452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on pull request #452: [FLINK-30187] Get operator log considering namespace
Posted by GitBox <gi...@apache.org>.
gaborgsomogyi commented on PR #452:
URL: https://github.com/apache/flink-kubernetes-operator/pull/452#issuecomment-1326176132
cc @gyfora
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org