You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dheerajturaga (via GitHub)" <gi...@apache.org> on 2026/07/25 20:11:31 UTC
[PR] UI: Highlight selected Grid task square [airflow]
dheerajturaga opened a new pull request, #70451:
URL: https://github.com/apache/airflow/pull/70451
Highlight the selected task instance square in Grid view so it is easier to identify the currently open task.
The highlight is scoped to the selected Dag run and task, so selecting a task no longer highlights the same task across every visible Dag run column. Dark mode uses a lighter outline color for better contrast.
Tests added for selected task highlighting, dark-mode outline token selection, different-task behavior, and same-task/different-run behavior.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Codex (GPT-5)
Generated-by: Codex (GPT-5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Highlight selected Grid task square [airflow]
Posted by "dheerajturaga (via GitHub)" <gi...@apache.org>.
dheerajturaga commented on PR #70451:
URL: https://github.com/apache/airflow/pull/70451#issuecomment-5084310186
> Thanks for the changes..
>
> The dark mode looks good, but the light mode is not that different from the original if we have lot of grids, maybe we need to increase the border.
>
> <img alt="Image" width="611" height="462" src="https://private-user-images.githubusercontent.com/48172486/626779341-076e8247-5478-4463-8f28-a7626cb28879.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODUwODI4MDAsIm5iZiI6MTc4NTA4MjUwMCwicGF0aCI6Ii80ODE3MjQ4Ni82MjY3NzkzNDEtMDc2ZTgyNDctNTQ3OC00NDYzLThmMjgtYTc2MjZjYjI4ODc5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjA3MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwNzI2VDE2MTUwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcwOTRjYmQ3ZGNlZjEwZjhmZmMxM2EwNjU4MTZhODhmMWIwNmY4ZTE0Zjk5M2Q1NzRjMjYyZDdhZmZhZjNkZWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRnBuZyJ9.G1Gkj8ovYv68bDOrdNe66R78S9gssMRiwFjeZSr0K3Q">
Make it thicker 2px
<img width="920" height="642" alt="image" src="https://github.com/user-attachments/assets/7337a9ea-e3bf-4857-bd73-bf17657c8021" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Highlight selected Grid task square [airflow]
Posted by "dheerajturaga (via GitHub)" <gi...@apache.org>.
dheerajturaga commented on PR #70451:
URL: https://github.com/apache/airflow/pull/70451#issuecomment-5122995235
> Adding a focus highlight makes sense. But why get rid of the row highlight?
Done!
<img width="847" height="556" alt="image" src="https://github.com/user-attachments/assets/2b942d37-c3f8-4db4-8926-270f671057d2" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Highlight selected Grid task square [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #70451:
URL: https://github.com/apache/airflow/pull/70451#issuecomment-5092958302
Adding a focus highlight makes sense. But why get rid of the row highlight?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Highlight selected Grid task square [airflow]
Posted by "dheerajturaga (via GitHub)" <gi...@apache.org>.
dheerajturaga commented on PR #70451:
URL: https://github.com/apache/airflow/pull/70451#issuecomment-5170905066
@bbovenzi , @shubhamraj-git ok to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Highlight selected Grid task square [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #70451:
URL: https://github.com/apache/airflow/pull/70451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Highlight selected Grid task square [airflow]
Posted by "dheerajturaga (via GitHub)" <gi...@apache.org>.
dheerajturaga commented on PR #70451:
URL: https://github.com/apache/airflow/pull/70451#issuecomment-5095845486
> Adding a focus highlight makes sense. But why get rid of the row highlight?
Good catch, That wasnt my intent. Let me fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: Highlight selected Grid task square [airflow]
Posted by "vatsrahul1001 (via GitHub)" <gi...@apache.org>.
vatsrahul1001 commented on PR #70451:
URL: https://github.com/apache/airflow/pull/70451#issuecomment-5130060902
Moving to 3.4.0 as this new addition suits minot better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org