You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/22 16:23:10 UTC

[GitHub] [superset] nytai opened a new pull request #13284: fix(listview): preserve bulk selections when view mode is changed

nytai opened a new pull request #13284:
URL: https://github.com/apache/superset/pull/13284


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Quickfix for: https://github.com/apache/superset/pull/13245#issuecomment-782521554
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   N/A 
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   Manual test:
   - bulk selected rows are preserved when the view mode is toggled from list to card and vice versa.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc commented on pull request #13284: fix(listview): preserve bulk selections when view mode is changed

Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13284:
URL: https://github.com/apache/superset/pull/13284#issuecomment-783857028


   Thanks for the fix! LGTM ✅
   https://user-images.githubusercontent.com/67837651/108800099-13306a80-7547-11eb-9c0d-b95282639020.mov
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc edited a comment on pull request #13284: fix(listview): preserve bulk selections when view mode is changed

Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13284:
URL: https://github.com/apache/superset/pull/13284#issuecomment-783857028


   Thanks for the fix! LGTM ✅ 
   
   https://user-images.githubusercontent.com/67837651/108800124-25aaa400-7547-11eb-8a64-2820db1b4fed.mov
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai merged pull request #13284: fix(listview): preserve bulk selections when view mode is changed

Posted by GitBox <gi...@apache.org>.
nytai merged pull request #13284:
URL: https://github.com/apache/superset/pull/13284


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org