[GitHub] [buildstream] nanonyme commented on a change in pull request #1576: _sandboxbwrap.py: try to support architectures that don't match host

[GitBox <gi...@apache.org>]

nanonyme commented on a change in pull request #1576:
URL: https://github.com/apache/buildstream/pull/1576#discussion_r792089210



##########
File path: buildstream/sandbox/_sandboxbwrap.py
##########
@@ -58,11 +66,25 @@ def __init__(self, *args, **kwargs):
         host_os, _, _, _, host_arch = os.uname()
         config = self._get_config()
 
-        # We can't do builds for another host or architecture except 32 bit on 64 bit
+        # We can't do builds for another host OS
         if config.build_os != host_os:
             raise SandboxError("Configured and host OS don't match.")
 
         if config.build_arch != host_arch:
+            try:
+                archtest = utils.get_host_tool('arch-test')

Review comment:
       My only concern with this is availability of arch-test. I'm sort of wondering what would be the problem of just removing all this sanitation and only keeping linux32 parts. Build will fail anyway if CPU arches don't match. Why does BuildStream need to check? It's quite complex to do so.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org