You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/07 05:51:19 UTC
[GitHub] [flink] wuchong opened a new pull request #10782:
[FLINK-14200][table] Fix NPE for Temporal Table Function Join when left
side is a query instead of a source
wuchong opened a new pull request #10782: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10782
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
**This is a cherry-pick of #10763 to release 1.9.**
Fix NPE when left input is a query (e.g. a filter/project/temporal join) in temporal table function join.
## Brief change log
- Get the RelOptSchema from the leaf RelNode which holds the non-null RelOptSchema
## Verifying this change
- Add a plan test that left input is a filter query
- Add a IT case that left input is a temporal join
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wuchong merged pull request #10782: [FLINK-14200][table]
Fix NPE for Temporal Table Function Join when left side is a query instead
of a source
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #10782: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10782
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10782: [FLINK-14200][table]
Fix NPE for Temporal Table Function Join when left side is a query instead
of a source
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10782: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10782#issuecomment-571447104
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a34bb7a1756ac11120f9656cc09b2e62c7a40300 (Tue Jan 07 05:54:24 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10782:
[FLINK-14200][table] Fix NPE for Temporal Table Function Join when left
side is a query instead of a source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10782: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10782#issuecomment-571449210
<!--
Meta data
Hash:2bb2d5edf64530f4548cc9a6f5c165f326739080 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:2bb2d5edf64530f4548cc9a6f5c165f326739080
Hash:dfac9f1c459c65f588d8c06832c5607515cfb3b8 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143341522 TriggerType:PUSH TriggerID:dfac9f1c459c65f588d8c06832c5607515cfb3b8
Hash:d8f1bdf635ec96ab04a77a03542ed0edb3295a27 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d8f1bdf635ec96ab04a77a03542ed0edb3295a27
-->
## CI report:
* 2bb2d5edf64530f4548cc9a6f5c165f326739080 UNKNOWN
* dfac9f1c459c65f588d8c06832c5607515cfb3b8 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143341522)
* d8f1bdf635ec96ab04a77a03542ed0edb3295a27 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10782: [FLINK-14200][table]
Fix NPE for Temporal Table Function Join when left side is a query instead
of a source
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10782: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10782#issuecomment-571449210
<!--
Meta data
Hash:2bb2d5edf64530f4548cc9a6f5c165f326739080 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:2bb2d5edf64530f4548cc9a6f5c165f326739080
-->
## CI report:
* 2bb2d5edf64530f4548cc9a6f5c165f326739080 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10782:
[FLINK-14200][table] Fix NPE for Temporal Table Function Join when left
side is a query instead of a source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10782: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10782#issuecomment-571449210
<!--
Meta data
Hash:2bb2d5edf64530f4548cc9a6f5c165f326739080 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:2bb2d5edf64530f4548cc9a6f5c165f326739080
Hash:dfac9f1c459c65f588d8c06832c5607515cfb3b8 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143341522 TriggerType:PUSH TriggerID:dfac9f1c459c65f588d8c06832c5607515cfb3b8
-->
## CI report:
* 2bb2d5edf64530f4548cc9a6f5c165f326739080 UNKNOWN
* dfac9f1c459c65f588d8c06832c5607515cfb3b8 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143341522)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10782:
[FLINK-14200][table] Fix NPE for Temporal Table Function Join when left
side is a query instead of a source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10782: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10782#issuecomment-571449210
<!--
Meta data
Hash:2bb2d5edf64530f4548cc9a6f5c165f326739080 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:2bb2d5edf64530f4548cc9a6f5c165f326739080
Hash:dfac9f1c459c65f588d8c06832c5607515cfb3b8 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143341522 TriggerType:PUSH TriggerID:dfac9f1c459c65f588d8c06832c5607515cfb3b8
Hash:d8f1bdf635ec96ab04a77a03542ed0edb3295a27 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/143353461 TriggerType:PUSH TriggerID:d8f1bdf635ec96ab04a77a03542ed0edb3295a27
-->
## CI report:
* 2bb2d5edf64530f4548cc9a6f5c165f326739080 UNKNOWN
* dfac9f1c459c65f588d8c06832c5607515cfb3b8 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143341522)
* d8f1bdf635ec96ab04a77a03542ed0edb3295a27 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/143353461)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10782:
[FLINK-14200][table] Fix NPE for Temporal Table Function Join when left
side is a query instead of a source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10782: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10782#issuecomment-571449210
<!--
Meta data
Hash:2bb2d5edf64530f4548cc9a6f5c165f326739080 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:2bb2d5edf64530f4548cc9a6f5c165f326739080
Hash:dfac9f1c459c65f588d8c06832c5607515cfb3b8 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/143341522 TriggerType:PUSH TriggerID:dfac9f1c459c65f588d8c06832c5607515cfb3b8
Hash:d8f1bdf635ec96ab04a77a03542ed0edb3295a27 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/143353461 TriggerType:PUSH TriggerID:d8f1bdf635ec96ab04a77a03542ed0edb3295a27
-->
## CI report:
* 2bb2d5edf64530f4548cc9a6f5c165f326739080 UNKNOWN
* dfac9f1c459c65f588d8c06832c5607515cfb3b8 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/143341522)
* d8f1bdf635ec96ab04a77a03542ed0edb3295a27 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/143353461)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10782:
[FLINK-14200][table] Fix NPE for Temporal Table Function Join when left
side is a query instead of a source
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10782: [FLINK-14200][table] Fix NPE for Temporal Table Function Join when left side is a query instead of a source
URL: https://github.com/apache/flink/pull/10782#issuecomment-571449210
<!--
Meta data
Hash:2bb2d5edf64530f4548cc9a6f5c165f326739080 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:2bb2d5edf64530f4548cc9a6f5c165f326739080
Hash:dfac9f1c459c65f588d8c06832c5607515cfb3b8 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:dfac9f1c459c65f588d8c06832c5607515cfb3b8
-->
## CI report:
* 2bb2d5edf64530f4548cc9a6f5c165f326739080 UNKNOWN
* dfac9f1c459c65f588d8c06832c5607515cfb3b8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services