You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/12/03 13:05:31 UTC

Re: [PR] remove `unalias` TableScan filters when create Physical Filter [arrow-datafusion]

alamb commented on code in PR #8404:
URL: https://github.com/apache/arrow-datafusion/pull/8404#discussion_r1413075898


##########
datafusion/core/src/physical_planner.rs:
##########
@@ -562,8 +562,7 @@ impl DefaultPhysicalPlanner {
                     // doesn't know (nor should care) how the relation was
                     // referred to in the query
                     let filters = unnormalize_cols(filters.iter().cloned());
-                    let unaliased: Vec<Expr> = filters.into_iter().map(unalias).collect();

Review Comment:
   I think we have to rely on our test coverage here, and given all the existing tests pass I agree!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org