You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/05/05 12:59:43 UTC
[GitHub] [incubator-kyuubi] gabrywu opened a new pull request, #2560: upgrade kyuubi-hive-jdbc hive version to 3.1.3
gabrywu opened a new pull request, #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560
### _Why are the changes needed?_
upgrade hive to 3.1.3 in the kyuubi-hive-jdbc module
### _How was this patch tested?_
use existing UTs to test this patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r866421880
##########
pom.xml:
##########
@@ -183,7 +183,7 @@
<maven.plugin.javadoc.version>3.3.0</maven.plugin.javadoc.version>
<!-- DO NOT bump 4.4.0, see https://github.com/apache/incubator-kyuubi/pull/441 -->
<!-- DO NOT bump 4.5.3, see https://github.com/apache/incubator-kyuubi/issues/708 -->
- <maven.plugin.scala.version>4.3.0</maven.plugin.scala.version>
+ <maven.plugin.scala.version>4.5.6</maven.plugin.scala.version>
Review Comment:
I tried, but failed to compile projects. It is necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r865900723
##########
pom.xml:
##########
@@ -183,7 +183,7 @@
<maven.plugin.javadoc.version>3.3.0</maven.plugin.javadoc.version>
<!-- DO NOT bump 4.4.0, see https://github.com/apache/incubator-kyuubi/pull/441 -->
<!-- DO NOT bump 4.5.3, see https://github.com/apache/incubator-kyuubi/issues/708 -->
- <maven.plugin.scala.version>4.3.0</maven.plugin.scala.version>
+ <maven.plugin.scala.version>4.5.6</maven.plugin.scala.version>
Review Comment:
Unnecessary change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867301389
##########
externals/kyuubi-hive-sql-engine/pom.xml:
##########
@@ -147,7 +147,13 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.zaxxer</groupId>
+ <artifactId>HikariCP</artifactId>
+ <version>2.6.1</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
nit: switch line 155 and 156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#issuecomment-1120194801
https://github.com/apache/incubator-kyuubi/issues/2492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867345030
##########
externals/kyuubi-hive-sql-engine/pom.xml:
##########
@@ -159,63 +165,63 @@
<outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory>
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
<plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-shade-plugin</artifactId>
- <configuration>
- <shadedArtifactAttached>false</shadedArtifactAttached>
- <artifactSet>
- <includes>
- <include>org.scala-lang:scala-library</include>
- <include>com.fasterxml.jackson.core:jackson-annotations</include>
- <include>com.fasterxml.jackson.core:jackson-core</include>
- <include>com.fasterxml.jackson.core:jackson-databind</include>
- <include>com.fasterxml.jackson.module:jackson-module-scala_2.12</include>
- <include>org.apache.kyuubi:kyuubi-common_${scala.binary.version}</include>
- <include>org.apache.kyuubi:kyuubi-events_${scala.binary.version}</include>
- <include>org.apache.kyuubi:kyuubi-ha_${scala.binary.version}</include>
- <include>org.apache.curator:curator-client</include>
- <include>org.apache.curator:curator-framework</include>
- <include>org.apache.curator:curator-recipes</include>
- </includes>
- </artifactSet>
- <filters>
- <filter>
- <artifact>*:*</artifact>
- <excludes>
- <exclude>META-INF/*.SF</exclude>
- <exclude>META-INF/*.DSA</exclude>
- <exclude>META-INF/*.RSA</exclude>
- <exclude>META-INF/DEPENDENCIES</exclude>
- <exclude>META-INF/LICENSE.txt</exclude>
- <exclude>META-INF/NOTICE.txt</exclude>
- <exclude>META-INF/maven/**</exclude>
- <exclude>LICENSE.txt</exclude>
- <exclude>NOTICE.txt</exclude>
- <exclude>mozilla/**</exclude>
- <exclude>**/module-info.class</exclude>
- </excludes>
- </filter>
- </filters>
- <relocations>
- <relocation>
- <pattern>org.apache.curator</pattern>
- <shadedPattern>${kyuubi.shade.packageName}.org.apache.curator</shadedPattern>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <configuration>
+ <shadedArtifactAttached>false</shadedArtifactAttached>
+ <artifactSet>
<includes>
- <include>org.apache.curator.**</include>
+ <include>org.scala-lang:scala-library</include>
+ <include>com.fasterxml.jackson.core:jackson-annotations</include>
+ <include>com.fasterxml.jackson.core:jackson-core</include>
+ <include>com.fasterxml.jackson.core:jackson-databind</include>
+ <include>com.fasterxml.jackson.module:jackson-module-scala_2.12</include>
Review Comment:
rollback this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867343675
##########
kyuubi-server/pom.xml:
##########
@@ -245,10 +257,6 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>*</artifactId>
</exclusion>
- <exclusion>
- <groupId>org.apache.hive</groupId>
- <artifactId>*</artifactId>
Review Comment:
We manage hive dependency manually instead of using maven transitive dependencies, because the hive dependencies is likely out of control if we do that. Please restore this exclusion and add everything explicitly.
PS: this rule only apply to hive, in most cases, we prefer use transitive dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867338468
##########
externals/kyuubi-hive-sql-engine/pom.xml:
##########
@@ -147,7 +147,13 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.zaxxer</groupId>
+ <artifactId>HikariCP</artifactId>
+ <version>2.6.1</version>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867345924
##########
pom.xml:
##########
@@ -202,6 +202,7 @@
<!-- Package to use when relocating shaded classes. -->
<kyuubi.shade.packageName>org.apache.kyuubi.shade</kyuubi.shade.packageName>
+ <hikaricp.version>2.6.1</hikaricp.version>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867953354
##########
pom.xml:
##########
@@ -1339,6 +1340,13 @@
<artifactId>gson</artifactId>
<version>${gson.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>com.zaxxer</groupId>
+ <artifactId>HikariCP</artifactId>
+ <version>${hikaricp.version}</version>
Review Comment:
We don't manage `<scope>` in `<dependencyManagement>` block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867301187
##########
externals/kyuubi-hive-sql-engine/pom.xml:
##########
@@ -159,63 +165,63 @@
<outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory>
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
<plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-shade-plugin</artifactId>
- <configuration>
- <shadedArtifactAttached>false</shadedArtifactAttached>
- <artifactSet>
- <includes>
- <include>org.scala-lang:scala-library</include>
- <include>com.fasterxml.jackson.core:jackson-annotations</include>
- <include>com.fasterxml.jackson.core:jackson-core</include>
- <include>com.fasterxml.jackson.core:jackson-databind</include>
- <include>com.fasterxml.jackson.module:jackson-module-scala_2.12</include>
- <include>org.apache.kyuubi:kyuubi-common_${scala.binary.version}</include>
- <include>org.apache.kyuubi:kyuubi-events_${scala.binary.version}</include>
- <include>org.apache.kyuubi:kyuubi-ha_${scala.binary.version}</include>
- <include>org.apache.curator:curator-client</include>
- <include>org.apache.curator:curator-framework</include>
- <include>org.apache.curator:curator-recipes</include>
- </includes>
- </artifactSet>
- <filters>
- <filter>
- <artifact>*:*</artifact>
- <excludes>
- <exclude>META-INF/*.SF</exclude>
- <exclude>META-INF/*.DSA</exclude>
- <exclude>META-INF/*.RSA</exclude>
- <exclude>META-INF/DEPENDENCIES</exclude>
- <exclude>META-INF/LICENSE.txt</exclude>
- <exclude>META-INF/NOTICE.txt</exclude>
- <exclude>META-INF/maven/**</exclude>
- <exclude>LICENSE.txt</exclude>
- <exclude>NOTICE.txt</exclude>
- <exclude>mozilla/**</exclude>
- <exclude>**/module-info.class</exclude>
- </excludes>
- </filter>
- </filters>
- <relocations>
- <relocation>
- <pattern>org.apache.curator</pattern>
- <shadedPattern>${kyuubi.shade.packageName}.org.apache.curator</shadedPattern>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <configuration>
+ <shadedArtifactAttached>false</shadedArtifactAttached>
+ <artifactSet>
<includes>
- <include>org.apache.curator.**</include>
+ <include>org.scala-lang:scala-library</include>
+ <include>com.fasterxml.jackson.core:jackson-annotations</include>
+ <include>com.fasterxml.jackson.core:jackson-core</include>
+ <include>com.fasterxml.jackson.core:jackson-databind</include>
+ <include>com.fasterxml.jackson.module:jackson-module-scala_2.12</include>
Review Comment:
Not related, but seems we include jackson w/o relocating, it may cause potential risk for class confliction.
I don't see content diff, it's just a format change? If yes, please revert this part to minimize the diff of this PR, we can handle it in seperated PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867332403
##########
kyuubi-hive-jdbc-shaded/pom.xml:
##########
@@ -112,6 +112,19 @@
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-standalone-metastore</artifactId>
Review Comment:
r u missing `hive-llap-client`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867952108
##########
pom.xml:
##########
@@ -1339,6 +1340,13 @@
<artifactId>gson</artifactId>
<version>${gson.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>com.zaxxer</groupId>
+ <artifactId>HikariCP</artifactId>
+ <version>${hikaricp.version}</version>
Review Comment:
how about adding `test` scope here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867346014
##########
kyuubi-hive-jdbc-shaded/src/main/resources/META-INF/NOTICE:
##########
@@ -41,22 +41,28 @@ Curator Framework
Copyright 2011-2017 The Apache Software Foundation
Hive Common
-Copyright 2021 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
Hive JDBC
-Copyright 2021 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
Hive Metastore
-Copyright 2021 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
+
+Hive Standalone Metastore
+Copyright 2022 The Apache Software Foundation
+
+Hive Llap Client
+Copyright 2022 The Apache Software Foundation
Hive Serde
-Copyright 2021 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
Hive Service
-Copyright 2021 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
Hive Service RPC
-Copyright 2019 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
Review Comment:
no, their version not updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867343906
##########
pom.xml:
##########
@@ -202,6 +202,7 @@
<!-- Package to use when relocating shaded classes. -->
<kyuubi.shade.packageName>org.apache.kyuubi.shade</kyuubi.shade.packageName>
+ <hikaricp.version>2.6.1</hikaricp.version>
Review Comment:
move to line 119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#issuecomment-1121147597
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867332426
##########
kyuubi-hive-jdbc-shaded/pom.xml:
##########
@@ -112,6 +112,19 @@
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-standalone-metastore</artifactId>
Review Comment:
we should udpate LICENSE and NOTICE file under the shaded module when change the shaded content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867345652
##########
kyuubi-server/pom.xml:
##########
@@ -245,10 +257,6 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>*</artifactId>
</exclusion>
- <exclusion>
- <groupId>org.apache.hive</groupId>
- <artifactId>*</artifactId>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867341076
##########
kyuubi-hive-jdbc-shaded/pom.xml:
##########
@@ -112,6 +112,19 @@
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-standalone-metastore</artifactId>
Review Comment:
> we should udpate LICENSE and NOTICE file under the shaded module when change the shaded content.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r865928019
##########
pom.xml:
##########
@@ -183,7 +183,7 @@
<maven.plugin.javadoc.version>3.3.0</maven.plugin.javadoc.version>
<!-- DO NOT bump 4.4.0, see https://github.com/apache/incubator-kyuubi/pull/441 -->
<!-- DO NOT bump 4.5.3, see https://github.com/apache/incubator-kyuubi/issues/708 -->
- <maven.plugin.scala.version>4.3.0</maven.plugin.scala.version>
+ <maven.plugin.scala.version>4.5.6</maven.plugin.scala.version>
Review Comment:
I will rollback it and try again. It's to resolve some compiling errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867344244
##########
kyuubi-hive-jdbc-shaded/src/main/resources/META-INF/NOTICE:
##########
@@ -41,22 +41,28 @@ Curator Framework
Copyright 2011-2017 The Apache Software Foundation
Hive Common
-Copyright 2021 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
Hive JDBC
-Copyright 2021 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
Hive Metastore
-Copyright 2021 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
+
+Hive Standalone Metastore
+Copyright 2022 The Apache Software Foundation
+
+Hive Llap Client
+Copyright 2022 The Apache Software Foundation
Hive Serde
-Copyright 2021 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
Hive Service
-Copyright 2021 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
Hive Service RPC
-Copyright 2019 The Apache Software Foundation
+Copyright 2022 The Apache Software Foundation
Review Comment:
Should we also update Hive Shims 0.23 and Hive Shims Common's year?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei closed pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
URL: https://github.com/apache/incubator-kyuubi/pull/2560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867323805
##########
externals/kyuubi-hive-sql-engine/pom.xml:
##########
@@ -159,63 +165,63 @@
<outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory>
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
<plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-shade-plugin</artifactId>
- <configuration>
- <shadedArtifactAttached>false</shadedArtifactAttached>
- <artifactSet>
- <includes>
- <include>org.scala-lang:scala-library</include>
- <include>com.fasterxml.jackson.core:jackson-annotations</include>
- <include>com.fasterxml.jackson.core:jackson-core</include>
- <include>com.fasterxml.jackson.core:jackson-databind</include>
- <include>com.fasterxml.jackson.module:jackson-module-scala_2.12</include>
- <include>org.apache.kyuubi:kyuubi-common_${scala.binary.version}</include>
- <include>org.apache.kyuubi:kyuubi-events_${scala.binary.version}</include>
- <include>org.apache.kyuubi:kyuubi-ha_${scala.binary.version}</include>
- <include>org.apache.curator:curator-client</include>
- <include>org.apache.curator:curator-framework</include>
- <include>org.apache.curator:curator-recipes</include>
- </includes>
- </artifactSet>
- <filters>
- <filter>
- <artifact>*:*</artifact>
- <excludes>
- <exclude>META-INF/*.SF</exclude>
- <exclude>META-INF/*.DSA</exclude>
- <exclude>META-INF/*.RSA</exclude>
- <exclude>META-INF/DEPENDENCIES</exclude>
- <exclude>META-INF/LICENSE.txt</exclude>
- <exclude>META-INF/NOTICE.txt</exclude>
- <exclude>META-INF/maven/**</exclude>
- <exclude>LICENSE.txt</exclude>
- <exclude>NOTICE.txt</exclude>
- <exclude>mozilla/**</exclude>
- <exclude>**/module-info.class</exclude>
- </excludes>
- </filter>
- </filters>
- <relocations>
- <relocation>
- <pattern>org.apache.curator</pattern>
- <shadedPattern>${kyuubi.shade.packageName}.org.apache.curator</shadedPattern>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <configuration>
+ <shadedArtifactAttached>false</shadedArtifactAttached>
+ <artifactSet>
<includes>
- <include>org.apache.curator.**</include>
+ <include>org.scala-lang:scala-library</include>
+ <include>com.fasterxml.jackson.core:jackson-annotations</include>
+ <include>com.fasterxml.jackson.core:jackson-core</include>
+ <include>com.fasterxml.jackson.core:jackson-databind</include>
+ <include>com.fasterxml.jackson.module:jackson-module-scala_2.12</include>
Review Comment:
A separate PR is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#issuecomment-1122010410
> thanks, merged to master
it's perfect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867301351
##########
externals/kyuubi-hive-sql-engine/pom.xml:
##########
@@ -147,7 +147,13 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.zaxxer</groupId>
+ <artifactId>HikariCP</artifactId>
+ <version>2.6.1</version>
Review Comment:
Extract it as a maven property and manage it under `<dependencyManagement>` block in root pom before using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#issuecomment-1120197309
Thanks @gabrywu for working on this, I think it is most there, @turboFei would you please check if this upgrade break anything you added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on a diff in pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on code in PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#discussion_r867338771
##########
kyuubi-hive-jdbc-shaded/pom.xml:
##########
@@ -112,6 +112,19 @@
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.hive</groupId>
+ <artifactId>hive-standalone-metastore</artifactId>
Review Comment:
> r u missing `hive-llap-client`?
hive-llap-client is in kyuubi-hive-jdbc/pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#issuecomment-1120117505
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2560](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f479f64) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/3208410d2c3b77ccb4360d7df7451d30bdefd137?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3208410) will **decrease** coverage by `0.46%`.
> The diff coverage is `1.23%`.
```diff
@@ Coverage Diff @@
## master #2560 +/- ##
============================================
- Coverage 63.69% 63.23% -0.47%
- Complexity 41 73 +32
============================================
Files 373 377 +4
Lines 17826 18261 +435
Branches 2378 2476 +98
============================================
+ Hits 11355 11547 +192
- Misses 5420 5618 +198
- Partials 1051 1096 +45
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/kyuubi/jdbc/hive/HttpBasicAuthInterceptor.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9IdHRwQmFzaWNBdXRoSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...uubi/jdbc/hive/HttpKerberosRequestInterceptor.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9IdHRwS2VyYmVyb3NSZXF1ZXN0SW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/kyuubi/jdbc/hive/HttpRequestInterceptorBase.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9IdHRwUmVxdWVzdEludGVyY2VwdG9yQmFzZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/kyuubi/jdbc/hive/HttpTokenAuthInterceptor.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9IdHRwVG9rZW5BdXRoSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...n/java/org/apache/kyuubi/jdbc/hive/JdbcColumn.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9KZGJjQ29sdW1uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...g/apache/kyuubi/jdbc/hive/KyuubiBaseResultSet.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9LeXV1YmlCYXNlUmVzdWx0U2V0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/kyuubi/jdbc/hive/KyuubiConnection.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9LeXV1YmlDb25uZWN0aW9uLmphdmE=) | `4.06% <0.00%> (-0.14%)` | :arrow_down: |
| [...pache/kyuubi/jdbc/hive/KyuubiDatabaseMetaData.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9LeXV1YmlEYXRhYmFzZU1ldGFEYXRhLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ache/kyuubi/jdbc/hive/KyuubiMetaDataResultSet.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9LeXV1YmlNZXRhRGF0YVJlc3VsdFNldC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...c/main/java/org/apache/kyuubi/jdbc/hive/Utils.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvaGl2ZS9VdGlscy5qYXZh) | `2.34% <0.00%> (+0.60%)` | :arrow_up: |
| ... and [37 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3208410...f479f64](https://codecov.io/gh/apache/incubator-kyuubi/pull/2560?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] gabrywu commented on pull request #2560: Upgrade kyuubi-hive-jdbc hive version to 3.1.3
Posted by GitBox <gi...@apache.org>.
gabrywu commented on PR #2560:
URL: https://github.com/apache/incubator-kyuubi/pull/2560#issuecomment-1118585376
@pan3793 @turboFei Please don't review this PR until all of the checks are successful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org