You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/31 19:47:08 UTC
[GitHub] [airflow] dstandish opened a new pull request #21239: Fix trigger dag redirect from task instance log view
dstandish opened a new pull request #21239:
URL: https://github.com/apache/airflow/pull/21239
When triggering a dag run from log view, we are redirected back to log view and
execution_date is not populated. This produces an error.
To resolve this we should not attempt to parse execution_date when it's empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr merged pull request #21239: Fix trigger dag redirect from task instance log view
Posted by GitBox <gi...@apache.org>.
uranusjr merged pull request #21239:
URL: https://github.com/apache/airflow/pull/21239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21239: Fix trigger dag redirect from task instance log view
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21239:
URL: https://github.com/apache/airflow/pull/21239#issuecomment-1026160068
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] HaloKo4 commented on a change in pull request #21239: Fix trigger dag redirect from task instance log view
Posted by GitBox <gi...@apache.org>.
HaloKo4 commented on a change in pull request #21239:
URL: https://github.com/apache/airflow/pull/21239#discussion_r796112414
##########
File path: airflow/www/views.py
##########
@@ -1377,7 +1377,7 @@ def log(self, session=None):
dag_id = request.args.get('dag_id')
task_id = request.args.get('task_id')
execution_date = request.args.get('execution_date')
- dttm = timezone.parse(execution_date)
+ dttm = timezone.parse(execution_date) if execution_date else None
Review comment:
isn't execution date deprecated and replaced with data interval?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #21239: Fix trigger dag redirect from task instance log view
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #21239:
URL: https://github.com/apache/airflow/pull/21239#discussion_r796276658
##########
File path: airflow/www/views.py
##########
@@ -1377,7 +1377,7 @@ def log(self, session=None):
dag_id = request.args.get('dag_id')
task_id = request.args.get('task_id')
execution_date = request.args.get('execution_date')
- dttm = timezone.parse(execution_date)
+ dttm = timezone.parse(execution_date) if execution_date else None
Review comment:
Eventually we want to change this to use `run_id` instead so let’s not bother changing it. This is considered internal and `execution_date` is only a variable name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] HaloKo4 commented on a change in pull request #21239: Fix trigger dag redirect from task instance log view
Posted by GitBox <gi...@apache.org>.
HaloKo4 commented on a change in pull request #21239:
URL: https://github.com/apache/airflow/pull/21239#discussion_r796112414
##########
File path: airflow/www/views.py
##########
@@ -1377,7 +1377,7 @@ def log(self, session=None):
dag_id = request.args.get('dag_id')
task_id = request.args.get('task_id')
execution_date = request.args.get('execution_date')
- dttm = timezone.parse(execution_date)
+ dttm = timezone.parse(execution_date) if execution_date else None
Review comment:
isn't execution date deprecated and replaced with run id?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org