You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/01/25 14:57:09 UTC

[GitHub] [drill] jnturton opened a new pull request #2434: [MINOR UPDATE] Remove bogus copy pasta test of log dir env var.

jnturton opened a new pull request #2434:
URL: https://github.com/apache/drill/pull/2434


   ## Description
   
   The removed test is a copy pasta of [the log dir test directly above it](https://github.com/apache/drill/blob/4aefcef2b665c5737471664912a26ef6ed9a6cfc/drill-yarn/src/test/java/org/apache/drill/yarn/scripts/TestScripts.java#L253) so does not test
   the native lib dir variables it claims to at all.  There is a legitimate test of the native lib 
   dir env vars present in the same test class.
   
   ## Documentation
   N/A
   
   ## Testing
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] jnturton commented on pull request #2434: [MINOR UPDATE] Remove bogus copy paste test of log dir env var.

Posted by GitBox <gi...@apache.org>.
jnturton commented on pull request #2434:
URL: https://github.com/apache/drill/pull/2434#issuecomment-1021909426


   @cgivre looks like we've found our way back to occasional test run timeout country.  We can launch them again but since this PR does nothing but delete one exactly duplicated test, I can't see that it can produce new failures...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] cgivre merged pull request #2434: [MINOR UPDATE] Remove bogus copy paste test of log dir env var.

Posted by GitBox <gi...@apache.org>.
cgivre merged pull request #2434:
URL: https://github.com/apache/drill/pull/2434


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org