You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/02 09:24:57 UTC
[GitHub] [apisix-dashboard] LiteSun opened a new pull request #2115: fix: after enable redirect HTTPS, websocket form field disappeared
LiteSun opened a new pull request #2115:
URL: https://github.com/apache/apisix-dashboard/pull/2115
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
fix: after enable redirect HTTPS, websocket form field disappeared
**Related issues**
fix #2087
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2115: fix: after enable redirect HTTPS, websocket form field disappeared
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #2115:
URL: https://github.com/apache/apisix-dashboard/pull/2115#issuecomment-911445421
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: 8089ceb9c6dc6f0b6ff4a40c9124305a55b16cd9
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61309862d016d40008481dc2](https://app.netlify.com/sites/apisix-dashboard/deploys/61309862d016d40008481dc2?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2115: fix: after enable redirect HTTPS, websocket form field disappeared
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #2115:
URL: https://github.com/apache/apisix-dashboard/pull/2115#discussion_r700930038
##########
File path: web/cypress/integration/route/create-edit-route-with-redirect-plugin.spec.js
##########
@@ -61,8 +61,8 @@ context('Create Edit and Delete Route with redirect plugin', () => {
cy.get(selector.customRedirectLabel).should('be.visible');
cy.get(selector.customRedirectUrI).should('be.visible');
cy.get(selector.customRedirectCode).should('be.visible');
- cy.get(selector.webSocketSelector).should('not.exist');
- cy.get(selector.enable_websocket_button).should('not.exist');
+ cy.get(selector.webSocketSelector).should('exist');
+ cy.get(selector.enable_websocket_button).should('exist');
Review comment:
would you please add an assertion to test enable websocket succseefully and check the info in configure view? @LiteSun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey merged pull request #2115: fix: after enable redirect HTTPS, websocket form field disappeared
Posted by GitBox <gi...@apache.org>.
imjoey merged pull request #2115:
URL: https://github.com/apache/apisix-dashboard/pull/2115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2115: fix: after enable redirect HTTPS, websocket form field disappeared
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2115:
URL: https://github.com/apache/apisix-dashboard/pull/2115#issuecomment-911445421
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: 8089ceb9c6dc6f0b6ff4a40c9124305a55b16cd9
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61309862d016d40008481dc2](https://app.netlify.com/sites/apisix-dashboard/deploys/61309862d016d40008481dc2?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2115--apisix-dashboard.netlify.app/](https://deploy-preview-2115--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2115: fix: after enable redirect HTTPS, websocket form field disappeared
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2115:
URL: https://github.com/apache/apisix-dashboard/pull/2115#issuecomment-911475137
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2115?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2115](https://codecov.io/gh/apache/apisix-dashboard/pull/2115?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8089ceb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/528699d1e10dac63a9408abc66bfe3d8e854284a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (528699d) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2115 +/- ##
==========================================
+ Coverage 67.27% 67.31% +0.04%
==========================================
Files 124 124
Lines 3279 3277 -2
Branches 799 797 -2
==========================================
Hits 2206 2206
+ Misses 1073 1071 -2
```
| Flag | Coverage Ξ | |
|---|---|---|
| frontend-e2e-test | `67.31% <100.00%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [web/src/pages/Route/components/Step1/MetaView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAxL01ldGFWaWV3LnRzeA==) | `100.00% <100.00%> (ΓΈ)` | |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2115/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `73.77% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2115?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2115?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [528699d...8089ceb](https://codecov.io/gh/apache/apisix-dashboard/pull/2115?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org