You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/30 14:04:00 UTC
[GitHub] [pulsar] wolfstudy opened a new pull request #14950: Add rate logger for repo
wolfstudy opened a new pull request #14950:
URL: https://github.com/apache/pulsar/pull/14950
Signed-off-by: xiaolongran <xi...@tencent.com>
### Motivation
When unacked messages reached to max unacked messages, the following logs will be quickly output to the log file, causing the broker's log file to switch within a short period of time.
### Modifications
The tool class of zookeeper RateLogger is introduced to limit the rate of log output, so as to avoid a large amount of output of related log information in a short period of time to trigger the scrolling of log files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #14950: Add rate logger for repo
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #14950:
URL: https://github.com/apache/pulsar/pull/14950#issuecomment-1083192957
I believe in this case the log should really be at debug level. The information is already available in the topic stats for debugging purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] wolfstudy commented on pull request #14950: Add rate logger for repo
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #14950:
URL: https://github.com/apache/pulsar/pull/14950#issuecomment-1083226008
> I believe in this case the log should really be at debug level. The information is already available in the topic stats for debugging purposes.
Yes, when the unack reaches the maximum threshold, we can get the number of unackedMessages through `pulsar-admin topics stats`, and get the maxUnackedMessage threshold from `pulsar-admin namespace policies`. But when this threshold is triggered, **Dispatcher read is blocked**. This behavior is actively triggered by the broker, which is not transparent enough to the client-side. We still need a more intuitive form to quickly locate this problem. It seems a reasonable way to output the specified log information to the broker log file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org