[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #1036: fix(c/driver/sqlite): Escape tablename in sqlite GetTableSchema

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #1036:
URL: https://github.com/apache/arrow-adbc/pull/1036#discussion_r1316358965


##########
c/validation/adbc_validation.cc:
##########
@@ -430,6 +430,20 @@ void ConnectionTest::TestMetadataGetTableSchema() {
                                     {"strings", NANOARROW_TYPE_STRING, NULLABLE}}));
 }
 
+void ConnectionTest::TestMetadataGetTableSchemaEscaping() {
+  if (!quirks()->supports_bulk_ingest(ADBC_INGEST_OPTION_MODE_CREATE)) {
+    GTEST_SKIP();
+  }
+  ASSERT_THAT(AdbcConnectionNew(&connection, &error), IsOkStatus(&error));
+  ASSERT_THAT(AdbcConnectionInit(&connection, &database, &error), IsOkStatus(&error));
+
+  Handle<ArrowSchema> schema;
+  ASSERT_NE(AdbcConnectionGetTableSchema(&connection, /*catalog=*/nullptr,
+                                         /*db_schema=*/nullptr, "(SELECT CURRENT_TIME)",
+                                         &schema.value, &error),
+            ADBC_STATUS_OK);

Review Comment:
   I thought I fixed this in the last commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org