[jira] [Commented] (ZOOKEEPER-1892) addrvec_next gets called twice when failing over to the next server

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932813#comment-13932813 ] 

Hadoop QA commented on ZOOKEEPER-1892:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12634331/ZOOKEEPER-1892.patch
  against trunk revision 1577019.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1956//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1956//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1956//console

This message is automatically generated.

> addrvec_next gets called twice when failing over to the next server
> -------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1892
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1892
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>            Reporter: Michi Mutsuzaki
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1892.patch
>
>
> zookeeper_interest() already calls zoo_cycle_next_server() when the socket is set to -1, so we shouldn't call addrvec_next in handle_error. This causes the next server to get skipped. Zookeeper_simpleSystem::testFirstServerDown fails unless the client gets connected to the server during the first round because the client keeps skipping the second server after the first round.



--
This message was sent by Atlassian JIRA
(v6.2#6252)