You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "houzhizhen (via GitHub)" <gi...@apache.org> on 2023/10/17 08:44:14 UTC
[PR] SPARK-45478: Codegen sum(decimal_column / 2) computes div twice [spark]
houzhizhen opened a new pull request, #43397:
URL: https://github.com/apache/spark/pull/43397
### What changes were proposed in this pull request?
All children of If should be eliminate common expression.
### Why are the changes needed?
There are three children in If: predicate, trueValue and falseValue.
There are two execution paths. 1: predicate and trueValue. 2: predicate and falseValue.
There are three conbinations of possible common subexpression. 1: predicate and trueValue. 2: predicate and falseValue. 3: trueValue and falseValue.
So if all possible common subexpression be eliminated, there is 2 3 possibility to improve the performance. For example, if there is common subexpression in predicate and falseValue, and common subexpression is executed only once, and it can improve the performance. Only there is common subexpression in trueValue and falseValue will not improve the performance and it will not draw back the performance, since whether trueValue and falseValue will be executed.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing testcase
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45478: Codegen sum(decimal_column / 2) computes div twice [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43397:
URL: https://github.com/apache/spark/pull/43397#issuecomment-1911208387
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-45478: Codegen sum(decimal_column / 2) computes div twice [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #43397: SPARK-45478: Codegen sum(decimal_column / 2) computes div twice
URL: https://github.com/apache/spark/pull/43397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org