You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "shishkovilja (via GitHub)" <gi...@apache.org> on 2026/06/19 08:58:34 UTC

[PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheClientReconnectDiscoveryData [ignite]

shishkovilja opened a new pull request, #13254:
URL: https://github.com/apache/ignite/pull/13254

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3558439972


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheGroupRecoveryState.java:
##########


Review Comment:
   Let's also fix it `zeroUpdateCounterPartitions`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13254:
URL: https://github.com/apache/ignite/pull/13254#issuecomment-4851632821

   ## Possible compatibility issues. Please, check rolling upgrade cases
   
   This PR modifies protected classes (with **Order** annotation).
   Changes to these classes can break rolling upgrade compatibility.
   
   **Affected files:**
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java`
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheReconnectInfo.java`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3593276074


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinNodeDiscoveryData.java:
##########
@@ -17,39 +17,41 @@
 
 package org.apache.ignite.internal.processors.cache;
 
-import java.io.IOException;
-import java.io.ObjectInputStream;
-import java.io.Serializable;
 import java.util.Map;
+import org.apache.ignite.internal.Order;
 import org.apache.ignite.internal.util.tostring.GridToStringInclude;
 import org.apache.ignite.internal.util.typedef.internal.S;
 import org.apache.ignite.lang.IgniteUuid;
+import org.apache.ignite.plugin.extensions.communication.Message;
 import org.jetbrains.annotations.Nullable;
 
-/**
- * Information about configured caches sent from joining node.
- */
-public class CacheJoinNodeDiscoveryData implements Serializable {
+/** Information about configured caches sent from joining node. */
+public class CacheJoinNodeDiscoveryData implements Message {
     /** */
-    private static final long serialVersionUID = 0L;
+    @Order(0)
+    @GridToStringInclude
+    Map<String, CacheJoinInfo> caches;
 
     /** */
+    @Order(1)
     @GridToStringInclude
-    private final Map<String, CacheInfo> caches;
+    Map<String, CacheJoinInfo> templates;
 
     /** */
+    @Order(2)
     @GridToStringInclude
-    private final Map<String, CacheInfo> templates;
+    IgniteUuid cacheDeploymentId;
 
     /** */
-    @GridToStringInclude
-    private final IgniteUuid cacheDeploymentId;
+    @Order(3)
+    boolean startCaches;
 
     /** */
-    private final boolean startCaches;
+    @Order(4)
+    @Nullable ClusterCacheGroupRecoveryData clusterCacheGrpRecoveryData;
 
     /** */

Review Comment:
   ```suggestion
       /** Default constructor for {@link MessageFactory}. */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "ignitetcbot (via GitHub)" <gi...@apache.org>.
ignitetcbot commented on PR #13254:
URL: https://github.com/apache/ignite/pull/13254#issuecomment-4875025701

   <!-- tcbot-analysis-comment chainBuildId=9168884 rerunBuildIds=9172090 -->
   ### TCBot Test Analysis
   
   * TeamCity: [--> Run :: All Results](https://ci2.ignite.apache.org/viewLog.html?buildId=9168884&buildTypeId=IgniteTests24Java8_RunAll)
   * Branch: `pull/13254/head`
   * Base: `master`
   * Tested commit: [030ceea](https://github.com/apache/ignite/pull/13254/commits/030ceeacfcb9a2c2d961f16eb56ae8dfe2b410e5)
   
   #### Possible Blockers (0)
   
   No blockers found.
   
   #### New Tests (0)
   
   No new tests found.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3593276074


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinNodeDiscoveryData.java:
##########
@@ -17,39 +17,41 @@
 
 package org.apache.ignite.internal.processors.cache;
 
-import java.io.IOException;
-import java.io.ObjectInputStream;
-import java.io.Serializable;
 import java.util.Map;
+import org.apache.ignite.internal.Order;
 import org.apache.ignite.internal.util.tostring.GridToStringInclude;
 import org.apache.ignite.internal.util.typedef.internal.S;
 import org.apache.ignite.lang.IgniteUuid;
+import org.apache.ignite.plugin.extensions.communication.Message;
 import org.jetbrains.annotations.Nullable;
 
-/**
- * Information about configured caches sent from joining node.
- */
-public class CacheJoinNodeDiscoveryData implements Serializable {
+/** Information about configured caches sent from joining node. */
+public class CacheJoinNodeDiscoveryData implements Message {
     /** */
-    private static final long serialVersionUID = 0L;
+    @Order(0)
+    @GridToStringInclude
+    Map<String, CacheJoinInfo> caches;
 
     /** */
+    @Order(1)
     @GridToStringInclude
-    private final Map<String, CacheInfo> caches;
+    Map<String, CacheJoinInfo> templates;
 
     /** */
+    @Order(2)
     @GridToStringInclude
-    private final Map<String, CacheInfo> templates;
+    IgniteUuid cacheDeploymentId;
 
     /** */
-    @GridToStringInclude
-    private final IgniteUuid cacheDeploymentId;
+    @Order(3)
+    boolean startCaches;
 
     /** */
-    private final boolean startCaches;
+    @Order(4)
+    @Nullable ClusterCacheGroupRecoveryData clusterCacheGrpRecoveryData;
 
     /** */

Review Comment:
   ```suggestion
       /** Default constructor for {@link MessageFactory}. */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13254:
URL: https://github.com/apache/ignite/pull/13254#issuecomment-4989178328

   ## Possible compatibility issues. Please, check rolling upgrade cases
   
   This PR modifies protected classes (with **Order** annotation).
   Changes to these classes can break rolling upgrade compatibility.
   
   **Affected files:**
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java`
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheReconnectInfo.java`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13254:
URL: https://github.com/apache/ignite/pull/13254#issuecomment-4983888441

   ## Possible compatibility issues. Please, check rolling upgrade cases
   
   This PR modifies protected classes (with **Order** annotation).
   Changes to these classes can break rolling upgrade compatibility.
   
   **Affected files:**
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java`
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheReconnectInfo.java`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13254:
URL: https://github.com/apache/ignite/pull/13254#issuecomment-4977806441

   ## Possible compatibility issues. Please, check rolling upgrade cases
   
   This PR modifies protected classes (with **Order** annotation).
   Changes to these classes can break rolling upgrade compatibility.
   
   **Affected files:**
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java`
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheReconnectInfo.java`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3558451345


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheGroupRecoveryState.java:
##########


Review Comment:
   lostPartitions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13254:
URL: https://github.com/apache/ignite/pull/13254#issuecomment-4990055186

   ## Possible compatibility issues. Please, check rolling upgrade cases
   
   This PR modifies protected classes (with **Order** annotation).
   Changes to these classes can break rolling upgrade compatibility.
   
   **Affected files:**
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java`
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheReconnectInfo.java`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3593258202


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java:
##########
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.internal.Order;
+import org.apache.ignite.internal.util.tostring.GridToStringInclude;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.plugin.extensions.communication.Message;
+
+/** */
+public class CacheJoinInfo implements Message {
+    /** */
+    @Order(0)
+    @GridToStringInclude
+    StoredCacheData cacheData;
+
+    /** */
+    @Order(1)
+    @GridToStringInclude
+    CacheType cacheType;
+
+    /** */
+    @Order(2)
+    @GridToStringInclude
+    boolean sql;
+
+    /** Flags added for future usage. */
+    @Order(3)
+    long flags;
+
+    /** Statically configured flag. */
+    @Order(4)
+    boolean staticallyConfigured;
+
+    /** */

Review Comment:
   ```suggestion
       /** Default constructor for {@link MessageFactory}. */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3593226549


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheClientReconnectDiscoveryData.java:
##########
@@ -17,175 +17,30 @@
 
 package org.apache.ignite.internal.processors.cache;
 
-import java.io.Serializable;
 import java.util.Map;
-import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.internal.Order;
 import org.apache.ignite.internal.util.typedef.internal.S;
-import org.apache.ignite.lang.IgniteUuid;
-
-/**
- * Discovery data sent from client reconnecting to cluster.
- */
-public class CacheClientReconnectDiscoveryData implements Serializable {
-    /** */
-    private static final long serialVersionUID = 0L;
+import org.apache.ignite.plugin.extensions.communication.Message;
 
+/** Discovery data sent from client reconnecting to cluster. */
+public class CacheClientReconnectDiscoveryData implements Message {
     /** */
-    private final Map<Integer, CacheGroupInfo> clientCacheGrps;
+    @Order(0)
+    Map<String, CacheReconnectInfo> clientCaches;
 
     /** */

Review Comment:
   ```suggestion
       /** Default constructor for {@link MessageFactory}. */
   ```



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java:
##########
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.internal.Order;
+import org.apache.ignite.internal.util.tostring.GridToStringInclude;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.plugin.extensions.communication.Message;
+
+/** */
+public class CacheJoinInfo implements Message {
+    /** */
+    @Order(0)
+    @GridToStringInclude
+    StoredCacheData cacheData;
+
+    /** */
+    @Order(1)
+    @GridToStringInclude
+    CacheType cacheType;
+
+    /** */
+    @Order(2)
+    @GridToStringInclude
+    boolean sql;
+
+    /** Flags added for future usage. */
+    @Order(3)
+    long flags;
+
+    /** Statically configured flag. */
+    @Order(4)
+    boolean staticallyConfigured;
+
+    /** */

Review Comment:
   ```suggestion
       /** Default constructor for {@link MessageFactory}. */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3593380961


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java:
##########
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.internal.Order;
+import org.apache.ignite.internal.util.tostring.GridToStringInclude;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.plugin.extensions.communication.Message;
+
+/** */

Review Comment:
   ```suggestion
   /** Cache information exchanged during node join. */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "ignitetcbot (via GitHub)" <gi...@apache.org>.
ignitetcbot commented on PR #13254:
URL: https://github.com/apache/ignite/pull/13254#issuecomment-4989234190

   <!-- tcbot-analysis-comment chainBuildId=9210921 rerunBuildIds=9212807,9212809 -->
   ### TCBot Test Analysis
   
   * TeamCity: [--> Run :: All Results](https://ci2.ignite.apache.org/viewLog.html?buildId=9210921&buildTypeId=IgniteTests24Java8_RunAll)
   * Branch: `pull/13254/head`
   * Base: `master`
   * Tested commit: [18b3b67](https://github.com/apache/ignite/pull/13254/commits/18b3b6757812a4d99b09f11294f34a4bc23c66ad)
   
   #### Possible Blockers (0)
   
   No blockers found.
   
   #### New Tests (0)
   
   No new tests found.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3557353474


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.internal.MarshallableMessage;
+import org.apache.ignite.internal.Order;
+import org.apache.ignite.internal.util.tostring.GridToStringInclude;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.marshaller.Marshaller;
+
+/** */
+public class CacheJoinInfo implements MarshallableMessage {
+    /** */
+    @GridToStringInclude
+    private StoredCacheData cacheData;
+
+    /** */
+    @Order(0)
+    byte[] cacheDataBytes;

Review Comment:
   Goof point!



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.internal.MarshallableMessage;
+import org.apache.ignite.internal.Order;
+import org.apache.ignite.internal.util.tostring.GridToStringInclude;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.marshaller.Marshaller;
+
+/** */
+public class CacheJoinInfo implements MarshallableMessage {
+    /** */
+    @GridToStringInclude
+    private StoredCacheData cacheData;
+
+    /** */
+    @Order(0)
+    byte[] cacheDataBytes;

Review Comment:
   Good point!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3558413930


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.internal.MarshallableMessage;
+import org.apache.ignite.internal.Order;
+import org.apache.ignite.internal.util.tostring.GridToStringInclude;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.marshaller.Marshaller;
+
+/** */
+public class CacheJoinInfo implements MarshallableMessage {
+    /** */
+    @GridToStringInclude
+    private StoredCacheData cacheData;
+
+    /** */
+    @Order(0)
+    byte[] cacheDataBytes;
+
+    /** */
+    @Order(1)
+    @GridToStringInclude
+    CacheType cacheType;
+
+    /** */
+    @Order(2)
+    @GridToStringInclude
+    boolean sql;
+
+    /** Flags added for future usage. */
+    @Order(3)
+    long flags;
+
+    /** Statically configured flag. */
+    @Order(4)
+    boolean staticallyConfigured;
+
+    /** */
+    public CacheJoinInfo() { }
+
+    /**
+     * @param cacheData Cache data.
+     * @param cacheType Cache type.
+     * @param sql SQL flag - {@code true} if cache was created with {@code CREATE TABLE}.
+     * @param flags Flags (for future usage).
+     * @param staticallyConfigured {@code true} if it was configured by static config and {@code false} otherwise.
+     */
+    public CacheJoinInfo(StoredCacheData cacheData, CacheType cacheType, boolean sql, long flags,
+        boolean staticallyConfigured) {
+        this.cacheData = cacheData;
+        this.cacheType = cacheType;
+        this.sql = sql;
+        this.flags = flags;
+        this.staticallyConfigured = staticallyConfigured;
+    }
+
+    /**
+     * @return Cache data.
+     */
+    public StoredCacheData cacheData() {
+        return cacheData;
+    }
+
+    /**
+     * @return Cache type.
+     */
+    public CacheType cacheType() {
+        return cacheType;
+    }
+
+    /**
+     * @return SQL flag - {@code true} if cache was created with {@code CREATE TABLE}.
+     */
+    public boolean sql() {
+        return sql;
+    }
+
+    /**
+     * @return {@code true} if it was configured by static config and {@code false} otherwise.
+     */
+    public boolean isStaticallyConfigured() {
+        return staticallyConfigured;
+    }
+
+    /**
+     * @return Long which bits represent some flags.
+     */
+    public long getFlags() {
+        return flags;
+    }
+
+    /**
+     * {@inheritDoc}
+     */

Review Comment:
   ```suggestion
       /** {@inheritDoc} */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "shishkovilja (via GitHub)" <gi...@apache.org>.
shishkovilja merged PR #13254:
URL: https://github.com/apache/ignite/pull/13254


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3593400968


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheReconnectInfo.java:
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.internal.Order;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.lang.IgniteUuid;
+import org.apache.ignite.plugin.extensions.communication.Message;
+
+/** */

Review Comment:
   ```suggestion
   /** Cache information from a reconnecting client node. */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3593226549


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheClientReconnectDiscoveryData.java:
##########
@@ -17,175 +17,30 @@
 
 package org.apache.ignite.internal.processors.cache;
 
-import java.io.Serializable;
 import java.util.Map;
-import org.apache.ignite.configuration.CacheConfiguration;
+import org.apache.ignite.internal.Order;
 import org.apache.ignite.internal.util.typedef.internal.S;
-import org.apache.ignite.lang.IgniteUuid;
-
-/**
- * Discovery data sent from client reconnecting to cluster.
- */
-public class CacheClientReconnectDiscoveryData implements Serializable {
-    /** */
-    private static final long serialVersionUID = 0L;
+import org.apache.ignite.plugin.extensions.communication.Message;
 
+/** Discovery data sent from client reconnecting to cluster. */
+public class CacheClientReconnectDiscoveryData implements Message {
     /** */
-    private final Map<Integer, CacheGroupInfo> clientCacheGrps;
+    @Order(0)
+    Map<String, CacheReconnectInfo> clientCaches;
 
     /** */

Review Comment:
   ```suggestion
       /** Default constructor for {@link MessageFactory}. */
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3558249443


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheGroupRecoveryState.java:
##########


Review Comment:
   ```suggestion
       public Set<Integer> zeroUpdateCounterPartitions() {
   ```



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheGroupRecoveryState.java:
##########


Review Comment:
   ```suggestion
       public Set<Integer> zeroUpdateCounterPartitions() {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13254:
URL: https://github.com/apache/ignite/pull/13254#issuecomment-4851746482

   ## Possible compatibility issues. Please, check rolling upgrade cases
   
   This PR modifies protected classes (with **Order** annotation).
   Changes to these classes can break rolling upgrade compatibility.
   
   **Affected files:**
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java`
   - `modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheReconnectInfo.java`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "ignitetcbot (via GitHub)" <gi...@apache.org>.
ignitetcbot commented on PR #13254:
URL: https://github.com/apache/ignite/pull/13254#issuecomment-4873873774

   <!-- tcbot-analysis-comment chainBuildId=9168884 rerunBuildIds=none -->
   ### TCBot Test Analysis
   
   * TeamCity: [--> Run :: All Results](https://ci2.ignite.apache.org/viewLog.html?buildId=9168884&buildTypeId=IgniteTests24Java8_RunAll)
   * Branch: `pull/13254/head`
   * Base: `master`
   * Tested commit: [030ceea](https://github.com/apache/ignite/pull/13254/commits/030ceeacfcb9a2c2d961f16eb56ae8dfe2b410e5)
   
   #### Possible Blockers (1)
   
   * [Thin client: PHP](https://ci2.ignite.apache.org/viewLog.html?buildId=9171840): 0 tests Exit Code 
     * Exit Code is a blocker. Base branch fail rate is 42,9%   
   
   #### New Tests (0)
   
   No new tests found.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3558252039


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheGroupRecoveryState.java:
##########


Review Comment:
   ```suggestion
       public Set<Integer> zeroUpdateCounterPartitions() {
   ```



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheGroupRecoveryState.java:
##########


Review Comment:
   ```suggestion
       public Set<Integer> zeroUpdateCounterPartitions() {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28787 Use MessageSerializer for CacheClientReconnectDiscoveryData and CacheJoinNodeDiscoveryData [ignite]

Posted by "wernerdv (via GitHub)" <gi...@apache.org>.
wernerdv commented on code in PR #13254:
URL: https://github.com/apache/ignite/pull/13254#discussion_r3557200007


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheJoinInfo.java:
##########
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.IgniteCheckedException;
+import org.apache.ignite.internal.MarshallableMessage;
+import org.apache.ignite.internal.Order;
+import org.apache.ignite.internal.util.tostring.GridToStringInclude;
+import org.apache.ignite.internal.util.typedef.internal.S;
+import org.apache.ignite.internal.util.typedef.internal.U;
+import org.apache.ignite.marshaller.Marshaller;
+
+/** */
+public class CacheJoinInfo implements MarshallableMessage {
+    /** */
+    @GridToStringInclude
+    private StoredCacheData cacheData;
+
+    /** */
+    @Order(0)
+    byte[] cacheDataBytes;

Review Comment:
   There's no need for that, StoredCacheData implements MarshallableMessage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org