Re: [PR] [VL] Adding context executor [incubator-gluten]

["jinchengchenghh (via GitHub)" <gi...@apache.org>]

jinchengchenghh commented on code in PR #11648:
URL: https://github.com/apache/incubator-gluten/pull/11648#discussion_r2872808172


##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -213,10 +213,18 @@ WholeStageResultIterator::WholeStageResultIterator(
 }
 
 std::shared_ptr<velox::core::QueryCtx> WholeStageResultIterator::createNewVeloxQueryCtx() {
+  int cpuThreads = veloxCfg_->get<int32_t>(kVeloxCpuExecutorThreads, kVeloxCpuExecutorThreadsDefault);
+  folly::Executor* executor = nullptr;
+  if (cpuThreads > 0) {
+    auto ctxExecutor = std::make_unique<folly::CPUThreadPoolExecutor>(cpuThreads);

Review Comment:
   Should reserve the ctxExecutor, otherwise it is released after the if block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org