You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2019/06/01 19:31:50 UTC
Re: Files w/o licenses
OK, I'll do it in a week if nobody beats me on it.
But I'll name those that should have done it before :p
Jacques
Le 28/05/2019 à 14:49, Jacques Le Roux a écrit :
> Hi Committers,
>
> Please guys make an effort: https://ci.apache.org/projects/ofbiz/rat-output.html
>
> I normally do it (add missing licences) but the RAT build was off for months and they piled up
>
> (OK now as it specifically depends on lares_ubuntu Buildbot server: https://issues.apache.org/jira/browse/INFRA-18500)
>
> You should be able to recognise your own commits, and it's better for you to learn and remember ;)
>
> Thanks
>
> Jacques
>
>
Re: Files w/o licenses
Posted by Mathieu Lirzin <ma...@nereide.fr>.
Jacques Le Roux <ja...@les7arts.com> writes:
> OK, I'll do it in a week if nobody beats me on it.
>
> But I'll name those that should have done it before :p
Shame! :-)
<https://www.youtube.com/watch?v=0Tna_vci9IY>
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Re: Files w/o licenses
Posted by Jacques Le Roux <ja...@les7arts.com>.
Hi Suraj,
Welcome
Actually Pierre is right: Buildbot RAT build should alert us.
Like other builds does for failing tests for instance.
I have created OFBIZ-11097 for that
Jacques
Le 10/06/2019 à 06:59, Suraj Khurana a écrit :
> Thanks Jacques for taking care of this.
>
> --
> Best Regards,
> Suraj Khurana
> Technical Consultant
> HotWax Systems
>
>
>
>
>
>
> On Sun, Jun 9, 2019 at 6:44 PM Jacques Le Roux <ja...@les7arts.com>
> wrote:
>
>> Done.
>>
>> Here we go, there were:
>>
>>
>> Unapproved Licenses:
>>
>> 1.
>> /home/buildslave/slave/ofbizTrunkFrameworkRat/build/applications/accounting/groovyScripts/test/AutoAcctgInvoiceTests.groovy
>> 2.
>> /home/buildslave/slave/ofbizTrunkFrameworkRat/build/applications/order/groovyScripts/test/OrderTests.groovy
>> 3.
>> /home/buildslave/slave/ofbizTrunkFrameworkRat/build/framework/service/src/main/java/org/apache/ofbiz/service/job/JobPriority.java
>> 4.
>> /home/buildslave/slave/ofbizTrunkFrameworkRat/build/plugins/msggateway/src/main/java/org/apache/ofbiz/msg91/Msg91Services.java
>>
>> 1. Patch Vivek Singh Bisen, commit Suraj
>> 2. Initial Pach Pawan Verma, commit Suraj
>> 3. Scott
>> 4. Patch Pritam Kute, commit Rishi. Went unnoticed by Mathieu later but
>> that does not count, it's harder to spot then but with RAT's help. The RAT
>> name was well chosen, reminds me Jack Nicholson in "The Departed" :)
>>
>> That's all for the shame today :D
>>
>> Jacques
>>
>>
>> Le 03/06/2019 à 13:07, Jacques Le Roux a écrit :
>>> Damn, I hope I'm not one of them ;)
>>>
>>> Le 03/06/2019 à 10:04, Scott Gray a écrit :
>>>> I hope you'll name the reviewers that missed them as well :-)
>>>>
>>>> On Sun, 2 Jun 2019 at 07:33, Jacques Le Roux <
>> jacques.le.roux@les7arts.com>
>>>> wrote:
>>>>
>>>>> OK, I'll do it in a week if nobody beats me on it.
>>>>>
>>>>> But I'll name those that should have done it before :p
>>>>>
>>>>> Jacques
>>>>>
>>>>> Le 28/05/2019 à 14:49, Jacques Le Roux a écrit :
>>>>>> Hi Committers,
>>>>>>
>>>>>> Please guys make an effort:
>>>>> https://ci.apache.org/projects/ofbiz/rat-output.html
>>>>>> I normally do it (add missing licences) but the RAT build was off for
>>>>> months and they piled up
>>>>>> (OK now as it specifically depends on lares_ubuntu Buildbot server:
>>>>> https://issues.apache.org/jira/browse/INFRA-18500)
>>>>>> You should be able to recognise your own commits, and it's better for
>>>>> you to learn and remember ;)
>>>>>> Thanks
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@ofbiz.apache.org
>>> For additional commands, e-mail: dev-help@ofbiz.apache.org
>>>
>>>
Re: Files w/o licenses
Posted by Suraj Khurana <su...@hotwax.co>.
Thanks Jacques for taking care of this.
--
Best Regards,
Suraj Khurana
Technical Consultant
HotWax Systems
On Sun, Jun 9, 2019 at 6:44 PM Jacques Le Roux <ja...@les7arts.com>
wrote:
> Done.
>
> Here we go, there were:
>
>
> Unapproved Licenses:
>
> 1.
> /home/buildslave/slave/ofbizTrunkFrameworkRat/build/applications/accounting/groovyScripts/test/AutoAcctgInvoiceTests.groovy
> 2.
> /home/buildslave/slave/ofbizTrunkFrameworkRat/build/applications/order/groovyScripts/test/OrderTests.groovy
> 3.
> /home/buildslave/slave/ofbizTrunkFrameworkRat/build/framework/service/src/main/java/org/apache/ofbiz/service/job/JobPriority.java
> 4.
> /home/buildslave/slave/ofbizTrunkFrameworkRat/build/plugins/msggateway/src/main/java/org/apache/ofbiz/msg91/Msg91Services.java
>
> 1. Patch Vivek Singh Bisen, commit Suraj
> 2. Initial Pach Pawan Verma, commit Suraj
> 3. Scott
> 4. Patch Pritam Kute, commit Rishi. Went unnoticed by Mathieu later but
> that does not count, it's harder to spot then but with RAT's help. The RAT
> name was well chosen, reminds me Jack Nicholson in "The Departed" :)
>
> That's all for the shame today :D
>
> Jacques
>
>
> Le 03/06/2019 à 13:07, Jacques Le Roux a écrit :
> > Damn, I hope I'm not one of them ;)
> >
> > Le 03/06/2019 à 10:04, Scott Gray a écrit :
> >> I hope you'll name the reviewers that missed them as well :-)
> >>
> >> On Sun, 2 Jun 2019 at 07:33, Jacques Le Roux <
> jacques.le.roux@les7arts.com>
> >> wrote:
> >>
> >>> OK, I'll do it in a week if nobody beats me on it.
> >>>
> >>> But I'll name those that should have done it before :p
> >>>
> >>> Jacques
> >>>
> >>> Le 28/05/2019 à 14:49, Jacques Le Roux a écrit :
> >>>> Hi Committers,
> >>>>
> >>>> Please guys make an effort:
> >>> https://ci.apache.org/projects/ofbiz/rat-output.html
> >>>> I normally do it (add missing licences) but the RAT build was off for
> >>> months and they piled up
> >>>> (OK now as it specifically depends on lares_ubuntu Buildbot server:
> >>> https://issues.apache.org/jira/browse/INFRA-18500)
> >>>> You should be able to recognise your own commits, and it's better for
> >>> you to learn and remember ;)
> >>>> Thanks
> >>>>
> >>>> Jacques
> >>>>
> >>>>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@ofbiz.apache.org
> > For additional commands, e-mail: dev-help@ofbiz.apache.org
> >
> >
>
Re: Files w/o licenses
Posted by Jacques Le Roux <ja...@les7arts.com>.
Done.
Here we go, there were:
Unapproved Licenses:
1. /home/buildslave/slave/ofbizTrunkFrameworkRat/build/applications/accounting/groovyScripts/test/AutoAcctgInvoiceTests.groovy
2. /home/buildslave/slave/ofbizTrunkFrameworkRat/build/applications/order/groovyScripts/test/OrderTests.groovy
3. /home/buildslave/slave/ofbizTrunkFrameworkRat/build/framework/service/src/main/java/org/apache/ofbiz/service/job/JobPriority.java
4. /home/buildslave/slave/ofbizTrunkFrameworkRat/build/plugins/msggateway/src/main/java/org/apache/ofbiz/msg91/Msg91Services.java
1. Patch Vivek Singh Bisen, commit Suraj
2. Initial Pach Pawan Verma, commit Suraj
3. Scott
4. Patch Pritam Kute, commit Rishi. Went unnoticed by Mathieu later but that does not count, it's harder to spot then but with RAT's help. The RAT
name was well chosen, reminds me Jack Nicholson in "The Departed" :)
That's all for the shame today :D
Jacques
Le 03/06/2019 à 13:07, Jacques Le Roux a écrit :
> Damn, I hope I'm not one of them ;)
>
> Le 03/06/2019 à 10:04, Scott Gray a écrit :
>> I hope you'll name the reviewers that missed them as well :-)
>>
>> On Sun, 2 Jun 2019 at 07:33, Jacques Le Roux <ja...@les7arts.com>
>> wrote:
>>
>>> OK, I'll do it in a week if nobody beats me on it.
>>>
>>> But I'll name those that should have done it before :p
>>>
>>> Jacques
>>>
>>> Le 28/05/2019 à 14:49, Jacques Le Roux a écrit :
>>>> Hi Committers,
>>>>
>>>> Please guys make an effort:
>>> https://ci.apache.org/projects/ofbiz/rat-output.html
>>>> I normally do it (add missing licences) but the RAT build was off for
>>> months and they piled up
>>>> (OK now as it specifically depends on lares_ubuntu Buildbot server:
>>> https://issues.apache.org/jira/browse/INFRA-18500)
>>>> You should be able to recognise your own commits, and it's better for
>>> you to learn and remember ;)
>>>> Thanks
>>>>
>>>> Jacques
>>>>
>>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ofbiz.apache.org
> For additional commands, e-mail: dev-help@ofbiz.apache.org
>
>
Re: Files w/o licenses
Posted by Jacques Le Roux <ja...@les7arts.com>.
Damn, I hope I'm not one of them ;)
Le 03/06/2019 à 10:04, Scott Gray a écrit :
> I hope you'll name the reviewers that missed them as well :-)
>
> On Sun, 2 Jun 2019 at 07:33, Jacques Le Roux <ja...@les7arts.com>
> wrote:
>
>> OK, I'll do it in a week if nobody beats me on it.
>>
>> But I'll name those that should have done it before :p
>>
>> Jacques
>>
>> Le 28/05/2019 à 14:49, Jacques Le Roux a écrit :
>>> Hi Committers,
>>>
>>> Please guys make an effort:
>> https://ci.apache.org/projects/ofbiz/rat-output.html
>>> I normally do it (add missing licences) but the RAT build was off for
>> months and they piled up
>>> (OK now as it specifically depends on lares_ubuntu Buildbot server:
>> https://issues.apache.org/jira/browse/INFRA-18500)
>>> You should be able to recognise your own commits, and it's better for
>> you to learn and remember ;)
>>> Thanks
>>>
>>> Jacques
>>>
>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ofbiz.apache.org
For additional commands, e-mail: dev-help@ofbiz.apache.org
Re: Files w/o licenses
Posted by Scott Gray <sc...@hotwaxsystems.com>.
I hope you'll name the reviewers that missed them as well :-)
On Sun, 2 Jun 2019 at 07:33, Jacques Le Roux <ja...@les7arts.com>
wrote:
> OK, I'll do it in a week if nobody beats me on it.
>
> But I'll name those that should have done it before :p
>
> Jacques
>
> Le 28/05/2019 à 14:49, Jacques Le Roux a écrit :
> > Hi Committers,
> >
> > Please guys make an effort:
> https://ci.apache.org/projects/ofbiz/rat-output.html
> >
> > I normally do it (add missing licences) but the RAT build was off for
> months and they piled up
> >
> > (OK now as it specifically depends on lares_ubuntu Buildbot server:
> https://issues.apache.org/jira/browse/INFRA-18500)
> >
> > You should be able to recognise your own commits, and it's better for
> you to learn and remember ;)
> >
> > Thanks
> >
> > Jacques
> >
> >
>