You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/10 13:01:56 UTC

[GitHub] [arrow] andygrove opened a new pull request #9979: ARROW-12251: [Rust] Add Ballista to CI

andygrove opened a new pull request #9979:
URL: https://github.com/apache/arrow/pull/9979


   Add `cargo build` and `cargo test` steps for Ballista. I will address fmt and clippy separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #9979: ARROW-12251: [Rust] Add Ballista to CI

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #9979:
URL: https://github.com/apache/arrow/pull/9979#issuecomment-817140055


   The build fails due to:
   
   ```
   error: failed to run custom build command for `snmalloc-sys v0.2.26`
   ```
   
   Root cause is that cmake is not installed.
   
   
   @Dandandan What is your recommendation? Do we need to use custom builder images?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #9979: ARROW-12251: [Rust] Add Ballista to CI

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #9979:
URL: https://github.com/apache/arrow/pull/9979#issuecomment-817332160


   I confirmed that CI ran the build and tests for Ballista so will go ahead and merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] Dandandan commented on pull request #9979: ARROW-12251: [Rust] Add Ballista to CI

Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9979:
URL: https://github.com/apache/arrow/pull/9979#issuecomment-817315885


   Thanks @mjp41 I think that's a great option.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9979: ARROW-12251: [Rust] Add Ballista to CI

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9979:
URL: https://github.com/apache/arrow/pull/9979#issuecomment-817133340


   https://issues.apache.org/jira/browse/ARROW-12251


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] mjp41 commented on pull request #9979: ARROW-12251: [Rust] Add Ballista to CI

Posted by GitBox <gi...@apache.org>.
mjp41 commented on pull request #9979:
URL: https://github.com/apache/arrow/pull/9979#issuecomment-817267751


   This came up for another project, and they added support for building snmalloc-[rs/sys] without cmake:
   
   > build_cc: use of cc crate instead of cmake (cmake still default) as builder (more platform agnostic)
   > https://github.com/SchrodingerZhu/snmalloc-rs/pull/118
   
   Personally, I would prefer snmalloc to be built with cmake, as that is what we test the most.  But, if that is not possible for your scenario, this option is there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove closed pull request #9979: ARROW-12251: [Rust] Add Ballista to CI

Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #9979:
URL: https://github.com/apache/arrow/pull/9979


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #9979: ARROW-12251: [Rust] Add Ballista to CI

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9979:
URL: https://github.com/apache/arrow/pull/9979#issuecomment-817136418


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9979?src=pr&el=h1) Report
   > Merging [#9979](https://codecov.io/gh/apache/arrow/pull/9979?src=pr&el=desc) (ac0e2c4) into [master](https://codecov.io/gh/apache/arrow/commit/81f652102737ea89c30de0cec1e94414b8740666?el=desc) (81f6521) will **decrease** coverage by `3.86%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9979/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9979?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9979      +/-   ##
   ==========================================
   - Coverage   82.70%   78.83%   -3.87%     
   ==========================================
     Files         257      285      +28     
     Lines       60486    63731    +3245     
   ==========================================
   + Hits        50027    50245     +218     
   - Misses      10459    13486    +3027     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9979?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [rust/datafusion/src/physical\_plan/merge.rs](https://codecov.io/gh/apache/arrow/pull/9979/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL21lcmdlLnJz) | `68.65% <0.00%> (-8.96%)` | :arrow_down: |
   | [...t/datafusion/src/physical\_plan/coalesce\_batches.rs](https://codecov.io/gh/apache/arrow/pull/9979/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2NvYWxlc2NlX2JhdGNoZXMucnM=) | `84.07% <0.00%> (-0.89%)` | :arrow_down: |
   | [rust/datafusion/src/execution/context.rs](https://codecov.io/gh/apache/arrow/pull/9979/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9leGVjdXRpb24vY29udGV4dC5ycw==) | `92.57% <0.00%> (-0.46%)` | :arrow_down: |
   | [rust/datafusion/src/execution/dataframe\_impl.rs](https://codecov.io/gh/apache/arrow/pull/9979/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9leGVjdXRpb24vZGF0YWZyYW1lX2ltcGwucnM=) | `88.88% <0.00%> (-0.22%)` | :arrow_down: |
   | [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9979/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `94.86% <0.00%> (-0.20%)` | :arrow_down: |
   | [rust/datafusion/src/datasource/parquet.rs](https://codecov.io/gh/apache/arrow/pull/9979/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL3BhcnF1ZXQucnM=) | `94.40% <0.00%> (-0.04%)` | :arrow_down: |
   | [rust/datafusion/tests/sql.rs](https://codecov.io/gh/apache/arrow/pull/9979/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3Rlc3RzL3NxbC5ycw==) | `98.45% <0.00%> (ø)` | |
   | [rust/datafusion/src/test/mod.rs](https://codecov.io/gh/apache/arrow/pull/9979/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy90ZXN0L21vZC5ycw==) | `100.00% <0.00%> (ø)` | |
   | [rust/datafusion/tests/dataframe.rs](https://codecov.io/gh/apache/arrow/pull/9979/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3Rlc3RzL2RhdGFmcmFtZS5ycw==) | `100.00% <0.00%> (ø)` | |
   | [rust/ballista/rust/scheduler/src/lib.rs](https://codecov.io/gh/apache/arrow/pull/9979/diff?src=pr&el=tree#diff-cnVzdC9iYWxsaXN0YS9ydXN0L3NjaGVkdWxlci9zcmMvbGliLnJz) | `0.00% <0.00%> (ø)` | |
   | ... and [46 more](https://codecov.io/gh/apache/arrow/pull/9979/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9979?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9979?src=pr&el=footer). Last update [e20a8b2...ac0e2c4](https://codecov.io/gh/apache/arrow/pull/9979?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #9979: ARROW-12251: [Rust] Add Ballista to CI

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #9979:
URL: https://github.com/apache/arrow/pull/9979#issuecomment-817330050


   I modified this PR to build without default features, just so we can enable CI quickly. I filed https://issues.apache.org/jira/browse/ARROW-12331 for the follow-up work for snmalloc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org