You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/05/03 18:31:00 UTC
[GitHub] [solr] risdenk commented on a diff in pull request #833: SOLR-16178: ZkController#fireEventListeners thread should be shutdown on close
risdenk commented on code in PR #833:
URL: https://github.com/apache/solr/pull/833#discussion_r864073976
##########
solr/core/src/java/org/apache/solr/cloud/ZkController.java:
##########
@@ -705,6 +709,8 @@ public void preClose() {
} finally {
ExecutorUtil.shutdownAndAwaitTermination(customThreadPool);
}
+
+ ExecutorUtil.shutdownAndAwaitTermination(fireEventListenersThreadPool);
Review Comment:
Yea I think thats fair. I did this in dd022238b06df8614a4bd52b2e6fee199b69c9a0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org