You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Hector Acosta (Code Review)" <ge...@cloudera.org> on 2019/04/03 17:17:39 UTC

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

Hector Acosta has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12922


Change subject: IMPALA-8382 Add support for SLES 12 SP3
......................................................................

IMPALA-8382 Add support for SLES 12 SP3

Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Testing: Ran a build, reployed a cluster on sles 12 sp3.
---
M bin/bootstrap_toolchain.py
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/12922/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12922 )

Change subject: IMPALA-8382 Add support for SLES 12 SP3
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/3991/


-- 
To view, visit http://gerrit.cloudera.org:8080/12922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Apr 2019 00:43:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12922 )

Change subject: IMPALA-8382 Add support for SLES 12 SP3
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12922/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12922/1//COMMIT_MSG@9
PS1, Line 9: Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Change-Id is usually at the end of the message?



-- 
To view, visit http://gerrit.cloudera.org:8080/12922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Apr 2019 00:42:41 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

Posted by "Hector Acosta (Code Review)" <ge...@cloudera.org>.
Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/12922 )

Change subject: IMPALA-8382 Add support for SLES 12 SP3
......................................................................


Patch Set 3:

> Patch Set 2: Commit message was updated.

Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/12922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 3
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Apr 2019 17:56:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12922 )

Change subject: IMPALA-8382 Add support for SLES 12 SP3
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3992/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 3
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Apr 2019 00:44:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has uploaded a new patch set (#2) to the change originally created by Hector Acosta. ( http://gerrit.cloudera.org:8080/12922 )

Change subject: IMPALA-8382 Add support for SLES 12 SP3
......................................................................

IMPALA-8382 Add support for SLES 12 SP3

Testing: Ran a build, reployed a cluster on sles 12 sp3.

Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
---
M bin/bootstrap_toolchain.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/22/12922/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12922 )

Change subject: IMPALA-8382 Add support for SLES 12 SP3
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 2
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Apr 2019 00:44:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12922 )

Change subject: IMPALA-8382 Add support for SLES 12 SP3
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3991/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/12922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Apr 2019 00:43:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12922 )

Change subject: IMPALA-8382 Add support for SLES 12 SP3
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 3
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sun, 07 Apr 2019 19:44:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12922 )

Change subject: IMPALA-8382 Add support for SLES 12 SP3
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 3
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 06 Apr 2019 05:45:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12922 )

Change subject: IMPALA-8382 Add support for SLES 12 SP3
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2623/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 1
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Apr 2019 17:51:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8382 Add support for SLES 12 SP3

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12922 )

Change subject: IMPALA-8382 Add support for SLES 12 SP3
......................................................................

IMPALA-8382 Add support for SLES 12 SP3

Testing: Ran a build, reployed a cluster on sles 12 sp3.

Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Reviewed-on: http://gerrit.cloudera.org:8080/12922
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M bin/bootstrap_toolchain.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3cb1311b15226f1130be7e1d79110d16e3287ef
Gerrit-Change-Number: 12922
Gerrit-PatchSet: 4
Gerrit-Owner: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>