You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "cpoerschke (via GitHub)" <gi...@apache.org> on 2024/05/24 14:01:36 UTC
[PR] fix Lucene[95-->99] typo in SchemaCodecFactory javadocs [solr]
cpoerschke opened a new pull request, #2478:
URL: https://github.com/apache/solr/pull/2478
Okay, I could have just pushed this typo fix directly but wanted to take opportunity to briefly wonder about the (lack of a?) connection between the Lucene `Codec` returned here and the `luceneMatchVersion` in `solrconfig.xml` configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] fix Lucene[95-->99] typo in SchemaCodecFactory javadocs [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on code in PR #2478:
URL: https://github.com/apache/solr/pull/2478#discussion_r1638122281
##########
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##########
@@ -151,8 +151,9 @@ public Codec getCodec() {
}
/**
- * This class exists because Lucene95HnswVectorsFormat's getMaxDimensions method is final and we
- * need to workaround that constraint to allow more than the default number of dimensions
+ * This class exists because {@link Lucene99HnswVectorsFormat#getMaxDimensions(String)} method is
+ * final and we need to workaround that constraint to allow more than the default number of
Review Comment:
Actually the method is not (no longer?) final: https://github.com/apache/lucene/blob/releases/lucene/9.10.0/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java#L220
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] fix Lucene[95-->99] typo in SchemaCodecFactory javadocs [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on code in PR #2478:
URL: https://github.com/apache/solr/pull/2478#discussion_r1638122281
##########
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##########
@@ -151,8 +151,9 @@ public Codec getCodec() {
}
/**
- * This class exists because Lucene95HnswVectorsFormat's getMaxDimensions method is final and we
- * need to workaround that constraint to allow more than the default number of dimensions
+ * This class exists because {@link Lucene99HnswVectorsFormat#getMaxDimensions(String)} method is
+ * final and we need to workaround that constraint to allow more than the default number of
Review Comment:
Actually the method is not (no longer?) final: https://github.com/apache/lucene/blob/releases/lucene/9.10.0/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java#L220
edit: never mind, the method is not final but the class is: https://github.com/apache/lucene/blob/releases/lucene/9.10.0/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java#L86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] fix Lucene[95-->99] typo in SchemaCodecFactory javadocs [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke merged PR #2478:
URL: https://github.com/apache/solr/pull/2478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] fix Lucene[95-->99] typo in SchemaCodecFactory javadocs [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #2478:
URL: https://github.com/apache/solr/pull/2478#discussion_r1623083017
##########
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##########
@@ -151,7 +151,7 @@ public Codec getCodec() {
}
/**
- * This class exists because Lucene95HnswVectorsFormat's getMaxDimensions method is final and we
+ * This class exists because Lucene99HnswVectorsFormat's getMaxDimensions method is final and we
Review Comment:
why not directly reference it using `{@link ...}`. It's take less chars overall! (no need to refer to "method")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org