You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/21 19:10:15 UTC
svn commit: r1775539 -
/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Save.java
Author: pmouawad
Date: Wed Dec 21 19:10:15 2016
New Revision: 1775539
URL: http://svn.apache.org/viewvc?rev=1775539&view=rev
Log:
Sonar : Fix errors and code smells
Modified:
jmeter/trunk/src/core/org/apache/jmeter/gui/action/Save.java
Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/action/Save.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Save.java?rev=1775539&r1=1775538&r2=1775539&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/gui/action/Save.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/gui/action/Save.java Wed Dec 21 19:10:15 2016
@@ -122,7 +122,7 @@ public class Save extends AbstractAction
@Override
public void doAction(ActionEvent e) throws IllegalUserActionException {
- HashTree subTree = null;
+ HashTree subTree;
boolean fullSave = false; // are we saving the whole tree?
if (!commands.contains(e.getActionCommand())) {
throw new IllegalUserActionException("Invalid user command:" + e.getActionCommand());
@@ -238,10 +238,10 @@ public class Save extends AbstractAction
log.warn("Failed to delete backup file " + expiredBackupFile.getName()); //$NON-NLS-1$
}
}
- } catch(RuntimeException | Error ex) {
+ } catch(RuntimeException ex) {
throw ex;
}
- catch (Throwable ex) {
+ catch (Exception ex) {
log.error("Error saving tree:", ex);
throw new IllegalUserActionException("Couldn't save test plan to file: " + updateFile, ex);
}