You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "dimas-b (via GitHub)" <gi...@apache.org> on 2025/12/13 04:47:15 UTC
[PR] Move integration tests to `polaris-server` [polaris]
dimas-b opened a new pull request, #3261:
URL: https://github.com/apache/polaris/pull/3261
`@QuarkusIntegrationTest` uses the regular server build with only non-test dependencies. Therefore, those tests naturally belong into the `server` module.
This change is as a prerequisite for #3252 to allow the `polaris-runtime-service` module to avoid having Polaris extensions as runtime dependencies. Extensions will be runtime dependencies only in the `polaris-server` module.
<!--
๐ Describe what changes you're proposing, especially breaking or user-facing changes.
๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more.
-->
## Checklist
- [ ] ๐ก๏ธ Don't disclose security issues! (contact security@apache.org)
- [ ] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes #
- [ ] ๐งช Added/updated tests with good coverage, or manually tested (and explained how)
- [ ] ๐ก Added comments for complex logic
- [ ] ๐งพ Updated `CHANGELOG.md` (if needed)
- [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move integration tests to `polaris-server` [polaris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3261: Move integration tests to `polaris-server`
URL: https://github.com/apache/polaris/pull/3261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move integration tests to `polaris-server` [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #3261:
URL: https://github.com/apache/polaris/pull/3261#discussion_r2621114482
##########
runtime/server/build.gradle.kts:
##########
@@ -53,6 +53,32 @@ dependencies {
// enforce the Quarkus _platform_ here, to get a consistent and validated set of dependencies
implementation(enforcedPlatform(libs.quarkus.bom))
implementation("io.quarkus:quarkus-container-image-docker")
+
+ testImplementation("io.quarkus:quarkus-junit5")
Review Comment:
I had to make a build config change and move a non-QuarkusIntegrationTest back to `runtime/service`... but I hope the end result is better now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move integration tests to `polaris-server` [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #3261:
URL: https://github.com/apache/polaris/pull/3261#discussion_r2619930403
##########
runtime/server/build.gradle.kts:
##########
@@ -53,6 +53,32 @@ dependencies {
// enforce the Quarkus _platform_ here, to get a consistent and validated set of dependencies
implementation(enforcedPlatform(libs.quarkus.bom))
implementation("io.quarkus:quarkus-container-image-docker")
+
+ testImplementation("io.quarkus:quarkus-junit5")
Review Comment:
Two questions / doubts here:
1. Why modify the `testImplementation` configuration here? I don't think it applies to integration tests.
2. Do we need to add `testImplementation(enforcedPlatform(libs.quarkus.bom))`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move integration tests to `polaris-server` [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #3261:
URL: https://github.com/apache/polaris/pull/3261#discussion_r2623329031
##########
runtime/service/src/test/java/org/apache/polaris/service/it/ServiceProducersIT.java:
##########
Review Comment:
Shouldn't we rename this test to something ending with `Test`? It is also oddly designed, the nested class seems unnecessary.
##########
runtime/service/src/test/java/org/apache/polaris/service/it/ServiceProducersIT.java:
##########
Review Comment:
BTW: the nested test class is not being executed, it is lacking the `@Nested` annotation. All in all, I think this test class could be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move integration tests to `polaris-server` [polaris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3261:
URL: https://github.com/apache/polaris/pull/3261#issuecomment-3762508580
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move integration tests to `polaris-server` [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #3261:
URL: https://github.com/apache/polaris/pull/3261#discussion_r2619968187
##########
runtime/server/build.gradle.kts:
##########
@@ -53,6 +53,32 @@ dependencies {
// enforce the Quarkus _platform_ here, to get a consistent and validated set of dependencies
implementation(enforcedPlatform(libs.quarkus.bom))
implementation("io.quarkus:quarkus-container-image-docker")
+
+ testImplementation("io.quarkus:quarkus-junit5")
Review Comment:
oops, my mistake. Thx for catching it... will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org