You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/03 14:26:26 UTC
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19841: Redesign JDBCRepository and H2Repository
codecov-commenter commented on PR #19841:
URL: https://github.com/apache/shardingsphere/pull/19841#issuecomment-1204022358
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19841](https://codecov.io/gh/apache/shardingsphere/pull/19841?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9aaa2f7) into [master](https://codecov.io/gh/apache/shardingsphere/commit/19265081c966cb0a839267b060593b258b0883b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1926508) will **increase** coverage by `0.11%`.
> The diff coverage is `82.78%`.
```diff
@@ Coverage Diff @@
## master #19841 +/- ##
============================================
+ Coverage 60.01% 60.13% +0.11%
- Complexity 2408 2410 +2
============================================
Files 3856 3853 -3
Lines 54860 54947 +87
Branches 7684 7706 +22
============================================
+ Hits 32924 33040 +116
+ Misses 19107 19072 -35
- Partials 2829 2835 +6
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ode/repository/standalone/jdbc/JDBCRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/19841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtc3RhbmRhbG9uZS1tb2RlL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5L3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5LWpkYmMvc2hhcmRpbmdzcGhlcmUtc3RhbmRhbG9uZS1tb2RlLXJlcG9zaXRvcnktamRiYy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL3JlcG9zaXRvcnkvc3RhbmRhbG9uZS9qZGJjL0pEQkNSZXBvc2l0b3J5LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...min/postgresql/PostgreSQLAdminExecutorCreator.java](https://codecov.io/gh/apache/shardingsphere/pull/19841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2FkbWluL3Bvc3RncmVzcWwvUG9zdGdyZVNRTEFkbWluRXhlY3V0b3JDcmVhdG9yLmphdmE=) | `89.74% <60.00%> (+2.24%)` | :arrow_up: |
| [...executor/ReplayRequiredSessionVariablesLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/19841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2FkbWluL2V4ZWN1dG9yL1JlcGxheVJlcXVpcmVkU2Vzc2lvblZhcmlhYmxlc0xvYWRlci5qYXZh) | `75.00% <75.00%> (ø)` | |
| [...ication/jdbc/connection/JDBCBackendConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/19841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvY29ubmVjdGlvbi9KREJDQmFja2VuZENvbm5lY3Rpb24uamF2YQ==) | `82.99% <86.66%> (+1.62%)` | :arrow_up: |
| [...ckend/session/RequiredSessionVariableRecorder.java](https://codecov.io/gh/apache/shardingsphere/pull/19841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9zZXNzaW9uL1JlcXVpcmVkU2Vzc2lvblZhcmlhYmxlUmVjb3JkZXIuamF2YQ==) | `94.28% <94.28%> (ø)` | |
| [...apache/shardingsphere/sharding/rule/TableRule.java](https://codecov.io/gh/apache/shardingsphere/pull/19841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcnVsZS9UYWJsZVJ1bGUuamF2YQ==) | `82.40% <100.00%> (ø)` | |
| [...sitory/standalone/h2/H2JDBCRepositoryProvider.java](https://codecov.io/gh/apache/shardingsphere/pull/19841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtc3RhbmRhbG9uZS1tb2RlL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5L3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5LWpkYmMvc2hhcmRpbmdzcGhlcmUtc3RhbmRhbG9uZS1tb2RlLXJlcG9zaXRvcnktamRiYy1oMi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9yZXBvc2l0b3J5L3N0YW5kYWxvbmUvaDIvSDJKREJDUmVwb3NpdG9yeVByb3ZpZGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...re/mode/repository/standalone/h2/H2Repository.java](https://codecov.io/gh/apache/shardingsphere/pull/19841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtc3RhbmRhbG9uZS1tb2RlL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5L3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5LXByb3ZpZGVyL3NoYXJkaW5nc3BoZXJlLXN0YW5kYWxvbmUtbW9kZS1yZXBvc2l0b3J5LWpkYmMvc2hhcmRpbmdzcGhlcmUtc3RhbmRhbG9uZS1tb2RlLXJlcG9zaXRvcnktamRiYy1oMi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvbW9kZS9yZXBvc2l0b3J5L3N0YW5kYWxvbmUvaDIvSDJSZXBvc2l0b3J5LmphdmE=) | `92.85% <100.00%> (+7.14%)` | :arrow_up: |
| [...dmin/mysql/DefaultMySQLSessionVariableHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/19841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2FkbWluL215c3FsL0RlZmF1bHRNeVNRTFNlc3Npb25WYXJpYWJsZUhhbmRsZXIuamF2YQ==) | `100.00% <100.00%> (+100.00%)` | :arrow_up: |
| [...resql/DefaultPostgreSQLSessionVariableHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/19841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2FkbWluL3Bvc3RncmVzcWwvRGVmYXVsdFBvc3RncmVTUUxTZXNzaW9uVmFyaWFibGVIYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| ... and [34 more](https://codecov.io/gh/apache/shardingsphere/pull/19841/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org