You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by michellephung <gi...@git.apache.org> on 2015/02/27 21:12:34 UTC
[GitHub] couchdb-fauxton pull request: Truncates pagination if more than 10...
GitHub user michellephung opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/296
Truncates pagination if more than 10 pages of pagination
Current: if there are many pages, you can't reach the later databases, depending on the screen size
After this commit, you'll only be able to see 10 pages of pagination at a time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michellephung/couchdb-fauxton Pagination-for-many-pages-of-pagination
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/296.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #296
----
commit 707794f7bcc182acd597cb3bc27a9e528189b313
Author: michellephung@gmail.com <mi...@gmail.com>
Date: 2015-02-27T20:05:17Z
Truncates pagination if more than 10 pages of pagination
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Truncates pagination if more than 10...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/296#issuecomment-77258020
I wrote the tests. I hope they are clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Truncates pagination if more than 10...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/296#issuecomment-77337873
+1. Those are great tests @michellephung. Nice work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Truncates pagination if more than 10...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/296#issuecomment-76950371
This looks great. But it needs a test. Could you move your code into its own method. Then write a few mocha tests to prove it gives the correct values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Truncates pagination if more than 10...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/296
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Truncates pagination if more than 10...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/296#issuecomment-76909741
missing a test
pinging @garrensmith as he also work on the pagination, maybe you can merge your work into his or vice versa
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---