You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/04/22 05:11:08 UTC

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2698: Issue2620-RocksDB log path configurable

eolivelli commented on a change in pull request #2698:
URL: https://github.com/apache/bookkeeper/pull/2698#discussion_r618083511



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDB.java
##########
@@ -150,6 +152,13 @@ public KeyValueStorageRocksDB(String path, DbConfigType dbConfigType, ServerConf
                 options.setTableFormatConfig(tableOptions);
             }
 
+            // Configure file path
+            String logPath = conf.getString(ROCKSDB_LOG_PATH, "");
+            if (!logPath.isEmpty()) {
+                options.setDbLogDir(FileSystems.getDefault().getPath(logPath, subPath).toFile().toString());
+            }
+            String path = FileSystems.getDefault().getPath(basePath, subPath).toFile().toString();

Review comment:
       Can we log this path?

##########
File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageTest.java
##########
@@ -71,10 +75,10 @@ private static long fromArray(byte[] array) {
 
     @Test
     public void simple() throws Exception {
-        File tmpDir = File.createTempFile("bookie", "test");
-        tmpDir.delete();
+        File tmpDir = Files.createTempDirectory("bookie").toFile();

Review comment:
       Can we switch this file to junit TemporaryFolder?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org