You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by yu...@apache.org on 2018/03/05 07:20:34 UTC

[rocketmq] branch master updated (c00cf3b -> dd8a60f)

This is an automated email from the ASF dual-hosted git repository.

yukon pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq.git.


 discard c00cf3b  Add a modified version of ISSUE_TEMPLATE that created by the bookkeeper project
     new dd8a60f  Add a modified version of ISSUE_TEMPLATE that created by the bookkeeper project

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (c00cf3b)
            \
             N -- N -- N   refs/heads/master (dd8a60f)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .github/ISSUE_TEMPLATE.md | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

-- 
To stop receiving notification emails like this one, please contact
yukon@apache.org.

[rocketmq] 01/01: Add a modified version of ISSUE_TEMPLATE that created by the bookkeeper project

Posted by yu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

yukon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/rocketmq.git

commit dd8a60f895fe3d457c98e762c2b53bc34ec5a3f3
Author: yukon <yu...@apache.org>
AuthorDate: Mon Mar 5 15:17:59 2018 +0800

    Add a modified version of ISSUE_TEMPLATE that created by the bookkeeper project
---
 .github/ISSUE_TEMPLATE.md        | 31 +++++++++++++++++++++++++++++++
 .github/PULL_REQUEST_TEMPLATE.md |  6 ++++--
 2 files changed, 35 insertions(+), 2 deletions(-)

diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
new file mode 100644
index 0000000..2cd7924
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE.md
@@ -0,0 +1,31 @@
+The issue tracker is **ONLY** used for bug report and feature request. 
+
+Any question or RocketMQ proposal please use our [mailing lists](http://rocketmq.apache.org/about/contact/).
+
+**BUG REPORT**
+
+1. Please describe the issue you observed:
+
+- What did you do (The steps to reproduce)?
+
+- What did you expect to see?
+
+- What did you see instead?
+
+2. Please tell us about your environment:
+
+3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):
+
+**FEATURE REQUEST**
+
+1. Please describe the feature you are requesting.
+
+2. Provide any additional detail on your proposed use case for this feature.
+
+2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
+
+4. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:
+
+- [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here, 
+- [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here,
+- ...
\ No newline at end of file
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 5d13fff..eb8cb83 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,3 +1,5 @@
+Please do not create a Pull Request without creating an issue first. 
+
 ## What is the purpose of the change
 
 XXXXX
@@ -12,8 +14,8 @@ XXXX
 
 Follow this checklist to help us incorporate your contribution quickly and easily:
 
-- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/ROCKETMQ/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
-- [ ] Format the pull request title like `[ROCKETMQ-XXX] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
+- [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
+- [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
 - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
 - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.

-- 
To stop receiving notification emails like this one, please contact
yukon@apache.org.