You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "krishna-dave206 (via GitHub)" <gi...@apache.org> on 2025/10/30 03:45:58 UTC
[PR] Added link to github discussions in the latest minutes [mahout]
krishna-dave206 opened a new pull request, #595:
URL: https://github.com/apache/mahout/pull/595
### Forgot to add the GitHub discussions link last time, so added it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to github discussions in the latest minutes [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on PR #595:
URL: https://github.com/apache/mahout/pull/595#issuecomment-3468423735
OK, what you did to papers.md is wildly wrong, this PR is unmergable until that is reverted.
Per the failling test, Wesley said in the mahout that he rebased and that fixed it, so try that.
Papers.md is supposed to pick up content from the _papers directory, you blew all of that away. If you think it should be blown away and changed, open an issue and we can discuss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to github discussions in the latest minutes [mahout]
Posted by "krishna-dave206 (via GitHub)" <gi...@apache.org>.
krishna-dave206 merged PR #595:
URL: https://github.com/apache/mahout/pull/595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to github discussions in the latest minutes [mahout]
Posted by "krishna-dave206 (via GitHub)" <gi...@apache.org>.
krishna-dave206 commented on PR #595:
URL: https://github.com/apache/mahout/pull/595#issuecomment-3466014625
@rawkintrevo @andrewmusselman The failing test appears to be some import issue in testing/test_overlap_measurement.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to github discussions in the latest minutes [mahout]
Posted by "guan404ming (via GitHub)" <gi...@apache.org>.
guan404ming commented on PR #595:
URL: https://github.com/apache/mahout/pull/595#issuecomment-3468245943
I've submit the [fix](https://github.com/apache/mahout/pull/594) which is merged now. It would pass after rebase on main branch.
> By that i mean, the test shouldn't have failed (or even run) for docs only changes.
You're right. They python test should only run on change for python related file. I will open another PR for fixing ci pipeline. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to github discussions in the latest minutes [mahout]
Posted by "rawkintrevo (via GitHub)" <gi...@apache.org>.
rawkintrevo commented on PR #595:
URL: https://github.com/apache/mahout/pull/595#issuecomment-3468104581
@guan404ming can you comment on this? (I think you touched test_overlap_measurement last).
Also @krishna-dave206 you need to revert papers.md i think that was included by mistake (based on the title)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to github discussions in the latest minutes [mahout]
Posted by "krishna-dave206 (via GitHub)" <gi...@apache.org>.
krishna-dave206 commented on PR #595:
URL: https://github.com/apache/mahout/pull/595#issuecomment-3468322911
@rawkintrevo I added some content in papers.md, then i added the github discussion link to minutes, so it got overwritten. The thing is I did two things:
1. Added some content to papers.md
2. Added github discussion link to latest minutes
that's why the title shows something else. Do review papers.md, and let me know if there's something which shouldn't be there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Added link to github discussions in the latest minutes [mahout]
Posted by "krishna-dave206 (via GitHub)" <gi...@apache.org>.
krishna-dave206 commented on PR #595:
URL: https://github.com/apache/mahout/pull/595#issuecomment-3468865518
@rawkintrevo I just reverted the changes in website/papers.md I'm sorry for the previous code that. Now, changes are reverted and no conflict or run tests failed is there. You can review it now. I agree `papers.md` should continue to pick up content from `_papers/`. I’ll open a separate, focused PR that only adds the paper summaries.
Apologies again — thanks for the quick review and for pointing this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mahout.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org