[GitHub] [incubator-doris] imay commented on a change in pull request #3326: [LSAN] Fix some memory leak detected by LSAN

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #3326: [LSAN] Fix some memory leak detected by LSAN
URL: https://github.com/apache/incubator-doris/pull/3326#discussion_r409274783
 
 

 ##########
 File path: be/src/exec/es/es_predicate.cpp
 ##########
 @@ -178,7 +179,7 @@ EsPredicate::EsPredicate(ExprContext* context,
 
 EsPredicate::~EsPredicate() {
     for(int i=0; i < _disjuncts.size(); i++) {
-        delete _disjuncts[i];
+        SAFE_DELETE(_disjuncts[i]);
 
 Review comment:
   It is safe to `delete nullptr`, and `_disjuncts` is cleared later on, so keep using delete is OK
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org