You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/21 19:48:40 UTC

[GitHub] [incubator-nuttx] nimish commented on a diff in pull request #6482: Use builtins for byteswapping

nimish commented on code in PR #6482:
URL: https://github.com/apache/incubator-nuttx/pull/6482#discussion_r903006533


##########
include/netinet/in.h:
##########
@@ -232,7 +232,7 @@
      ((((unsigned short)(ns)) >> 8) & 0x00ff))
 # endif
 # ifdef __has_builtin && __has_builtin(__builtin_bswap32)
-#  define HTONL(nl) ((unsigned long)__builtin_bswap32(((unsigned short) (nl))))
+#  define HTONL(nl) ((unsigned long)__builtin_bswap32(((unsigned long) (nl))))

Review Comment:
   squash merge it at the end?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org