[GitHub] [kafka] hachikuji commented on a change in pull request #9816: KAFKA-10761: Kafka Raft update log start offset

[GitBox <gi...@apache.org>]

hachikuji commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r552939181



##########
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##########
@@ -113,6 +140,20 @@ class KafkaMetadataLog(
     log.truncateTo(offset)
   }
 
+  override def truncateFullyToLatestSnapshot(): Boolean = {

Review comment:
       The fact that we have the high watermark in two places has always been unsatisfying, but I have not prioritized coming up with a solution. I have been inclined to say that `ReplicatedLog` owns the high watermark, so option 1 is consistent with that. I might be tempted to leave that for a separate PR though. In this case, since we are requesting a full truncation, it seems we could just set the high watermark to the snapshot offset?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org