You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/12/16 10:11:23 UTC

[GitHub] [logging-log4j2] zhuyou1234 opened a new pull request #631: async logger name can be empty。for compatible old version

zhuyou1234 opened a new pull request #631:
URL: https://github.com/apache/logging-log4j2/pull/631


    <AsyncLogger name="" level="info"
                        includeLocation="false" additivity="false">
   </AsyncLogger>
   
   should be allowed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [logging-log4j2] vy commented on pull request #631: async logger name can be empty。for compatible old version

Posted by GitBox <gi...@apache.org>.
vy commented on pull request #631:
URL: https://github.com/apache/logging-log4j2/pull/631#issuecomment-998327523


   @zhuyou1234, thanks for your contribution. I think allowing empty names were already a bug in the first place. Hence, I am inclined to keep the code in its current state (that is, enforcing non-empty names) with the cost of a slight backward incompatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [logging-log4j2] vy closed pull request #631: async logger name can be empty。for compatible old version

Posted by GitBox <gi...@apache.org>.
vy closed pull request #631:
URL: https://github.com/apache/logging-log4j2/pull/631


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org