You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/08/28 05:50:31 UTC

[GitHub] [fineract] fynmanoj opened a new pull request #1303: FINERACT-1120-TFA-authentication-issue-fix

fynmanoj opened a new pull request #1303:
URL: https://github.com/apache/fineract/pull/1303


   ## Description
   Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola commented on pull request #1303: FINERACT-1120-TFA-authentication-issue-fix

Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1303:
URL: https://github.com/apache/fineract/pull/1303#issuecomment-684162741


   The change itself looks OK to me - but I have no idea if it is enough to fix TFA, or if there are other issues that need to be resolved. Do we have any way of testing this or are there any instructions on how it should work? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #1303: FINERACT-1120-TFA-authentication-issue-fix

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1303:
URL: https://github.com/apache/fineract/pull/1303#issuecomment-696888447


   This appears to be the back-port of #1297 to 1.4.0 for FINERACT-1136 .. but 1.4.0 has meanwhile sailed without this. @fynmanoj @vidakovic do you want to just close this PR, or do something else with it? -- PS: If were were to still merge this PR to the 1.4.0 now, it would be very confusing... see FINERACT-1154.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #1303: FINERACT-1120-TFA-authentication-issue-fix

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1303:
URL: https://github.com/apache/fineract/pull/1303#issuecomment-696890882


   @avikganguly01 do you know more about this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] ptuomola closed pull request #1303: FINERACT-1120-TFA-authentication-issue-fix

Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #1303:
URL: https://github.com/apache/fineract/pull/1303


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #1303: FINERACT-1120-TFA-authentication-issue-fix

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1303:
URL: https://github.com/apache/fineract/pull/1303#issuecomment-696888447






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org