You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jon Schutz (JIRA)" <ji...@apache.org> on 2009/04/29 05:39:30 UTC
[jira] Created: (THRIFT-470) perl namespace for fb303
perl namespace for fb303
------------------------
Key: THRIFT-470
URL: https://issues.apache.org/jira/browse/THRIFT-470
Project: Thrift
Issue Type: Improvement
Reporter: Jon Schutz
Priority: Minor
Currently there is no namespace set in contrib/fb303/if/fb303.thrift for perl, resulting in generation of Constants.pm and Types.pm at root level, leaving them practically uninstallable/unusable due to potential for name conflict with other files.
Could we please add the following namespace line to fb303.thrift?
namespace perl Facebook.FB303
so the imports become Facebook::FB303::Constants etc, and everything plays nicely.
Patch:
--- thrift-20090428/contrib/fb303/if/fb303.thrift 2009-04-29 10:48:08.000000000 +0930
+++ thrift/contrib/fb303/if/fb303.thrift 2009-04-28 05:06:50.000000000 +0930
@@ -23,7 +23,6 @@
namespace java com.facebook.fb303
namespace cpp facebook.fb303
-namespace perl Facebook.FB303
/**
* Common status reporting mechanism across all services
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-470) perl namespace for fb303
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss resolved THRIFT-470.
--------------------------------
Resolution: Fixed
> perl namespace for fb303
> ------------------------
>
> Key: THRIFT-470
> URL: https://issues.apache.org/jira/browse/THRIFT-470
> Project: Thrift
> Issue Type: Improvement
> Reporter: Jon Schutz
> Priority: Minor
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> Currently there is no namespace set in contrib/fb303/if/fb303.thrift for perl, resulting in generation of Constants.pm and Types.pm at root level, leaving them practically uninstallable/unusable due to potential for name conflict with other files.
> Could we please add the following namespace line to fb303.thrift?
> namespace perl Facebook.FB303
> so the imports become Facebook::FB303::Constants etc, and everything plays nicely.
> Patch:
> --- thrift-20090428/contrib/fb303/if/fb303.thrift 2009-04-29 10:48:08.000000000 +0930
> +++ thrift/contrib/fb303/if/fb303.thrift 2009-04-28 05:06:50.000000000 +0930
> @@ -23,7 +23,6 @@
>
> namespace java com.facebook.fb303
> namespace cpp facebook.fb303
> -namespace perl Facebook.FB303
>
> /**
> * Common status reporting mechanism across all services
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.