You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "jayzhou2309 (via GitHub)" <gi...@apache.org> on 2026/10/02 03:39:09 UTC
[PR] fix(polar): respect radiusAxis axisTick.inside and axisLabel.inside. close #17434 [echarts]
jayzhou2309 opened a new pull request, #21776:
URL: https://github.com/apache/echarts/pull/21776
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Make `radiusAxis.axisTick.inside` and `radiusAxis.axisLabel.inside` flip the ticks and labels to the other side of the radius axis.
### Fixed issues
- #17434: invalid configuration of radiusAxis.axisLabel.inside and radiusAxis.axisTick.inside
## Details
### Before: What was the problem?
`layoutAxis` in `src/component/axis/RadiusAxisView.ts` passed `tickDirection: -1` and `labelDirection: -1` to `AxisBuilder` unconditionally. It never read `inside`, so both options were ignored. The cartesian (`cartesianAxisHelper.ts`) and single (`singleAxisHelper.ts`) axes do read them and negate the direction.
### After: How does it behave after the fixing?
`layoutAxis` reads `axisTick.inside` and `axisLabel.inside` and uses direction `1` when set, the same flip the cartesian and single axes do. Minor ticks follow `tickDirection` too. The default (`inside: false`) layout is unchanged.
## Document Info
One of the following should be checked.
- [x] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### Security Checking
- [ ] This PR uses security-sensitive Web APIs.
<!-- PLEASE CHECK IT AGAINST: <https://github.com/apache/echarts/wiki/Security-Checklist-for-Code-Contributors> -->
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
`test/ut/spec/component/axis/radiusAxis.test.ts` renders the option from the issue with `inside` off and on and checks the tick end offset and the label side.
- On `release` (acb285f24) the `inside: true` case fails: the tick ends at `-5` and the label stays on the default side. With this fix it ends at `5` and the label moves across.
- Full unit suite: 216 of 217 pass. The one failure, `time.test.ts` `roundTime_locale`, fails the same way on `release` without this change (it depends on the local timezone).
- `npx eslint` on the changed files and `npx tsc --noEmit` are clean.
### Merging options
- [x] Please squash the commits into a single one when merging.
### Other information
AI disclosure: an AI agent (Claude Code) reproduced the issue on `release`, wrote the test and the fix, and ran `npx jest --config test/ut/jest.config.cjs`, `npx eslint`, and `npx tsc --noEmit`.
---
<!-- oss-agent -->
<sub>🤖 Written and posted by an AI agent (Claude Code) on behalf of @jayzhou2309.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] fix(polar): respect radiusAxis axisTick.inside and axisLabel.inside. close #17434 [echarts]
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #21776:
URL: https://github.com/apache/echarts/pull/21776#issuecomment-5945167911
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
Please **DO NOT** commit the files in [dist](https://github.com/apache/echarts/tree/master/dist), [i18n](https://github.com/apache/echarts/tree/master/i18n), and [ssr/client/dist](https://github.com/apache/echarts/tree/master/ssr/client/dist) folders in a non-release pull request. These folders are for release use only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org