You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "gong (via GitHub)" <gi...@apache.org> on 2023/02/21 04:22:21 UTC
[GitHub] [inlong] gong commented on a diff in pull request #7394: [INLONG-7391][Sort] Support CSV format and dirty data collecting for StarRocks connector
gong commented on code in PR #7394:
URL: https://github.com/apache/inlong/pull/7394#discussion_r1112517722
##########
inlong-sort/sort-connectors/base/src/test/java/org/apache/inlong/sort/base/dirty/RegexReplaceTest.java:
##########
@@ -32,7 +32,7 @@ public void testRegexReplacement() throws IOException {
identifier[0] = "yizhouyang";
identifier[1] = "table2";
String pattern = "${database}-${table}-${DIRTY_MESSAGE}";
- String answer = DirtySinkHelper.regexReplace(pattern, DirtyType.BATCH_LOAD_ERROR, "mock message", identifier);
+ String answer = DirtySinkHelper.regexReplace(pattern, DirtyType.BATCH_LOAD_ERROR, "mock message");
Review Comment:
@Yizhou-Yang Please check this UT modication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org