You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/05/13 01:32:33 UTC
Re: Review Request 33155: Added tests for slave removal metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33155/
-----------------------------------------------------------
(Updated May 12, 2015, 11:32 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Added a missing call to stop the slave; the tests are no longer commented out now.
Note that I can't test the newly added replaced slave metric since we cannot restart a slave with the same PID currently.
Summary (updated)
-----------------
Added tests for slave removal metrics.
Bugs: MESOS-2485
https://issues.apache.org/jira/browse/MESOS-2485
Repository: mesos
Description
-------
I updated the existing tests to validate the metrics. However, it blocks the tests due to the slave metrics never getting satisfied. Added a TODO.
Diffs (updated)
-----
src/tests/master_tests.cpp 75ffadae64ece4e3ff53abeefa5f6e8e3690d402
src/tests/partition_tests.cpp 1018e479a77a6b533f2dd392fedbdccb80e3ac1f
src/tests/slave_tests.cpp 04e79ec061e767a82d40242be7884967942c50b6
Diff: https://reviews.apache.org/r/33155/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 33155: Added tests for slave removal metrics.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33155/#review83538
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33152, 33153, 33154, 33155]
All tests passed.
- Mesos ReviewBot
On May 12, 2015, 11:32 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33155/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 11:32 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2485
> https://issues.apache.org/jira/browse/MESOS-2485
>
>
> Repository: mesos
>
>
> Description
> -------
>
> I updated the existing tests to validate the metrics. However, it blocks the tests due to the slave metrics never getting satisfied. Added a TODO.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 75ffadae64ece4e3ff53abeefa5f6e8e3690d402
> src/tests/partition_tests.cpp 1018e479a77a6b533f2dd392fedbdccb80e3ac1f
> src/tests/slave_tests.cpp 04e79ec061e767a82d40242be7884967942c50b6
>
> Diff: https://reviews.apache.org/r/33155/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 33155: Added tests for slave removal metrics.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33155/#review83648
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 12, 2015, 11:32 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33155/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 11:32 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2485
> https://issues.apache.org/jira/browse/MESOS-2485
>
>
> Repository: mesos
>
>
> Description
> -------
>
> I updated the existing tests to validate the metrics. However, it blocks the tests due to the slave metrics never getting satisfied. Added a TODO.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 75ffadae64ece4e3ff53abeefa5f6e8e3690d402
> src/tests/partition_tests.cpp 1018e479a77a6b533f2dd392fedbdccb80e3ac1f
> src/tests/slave_tests.cpp 04e79ec061e767a82d40242be7884967942c50b6
>
> Diff: https://reviews.apache.org/r/33155/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>