You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/28 12:44:53 UTC
[GitHub] [arrow-rs] Jimexist opened a new pull request, #3210: WIP add more integration test for parquet bloom filter round trip tests
Jimexist opened a new pull request, #3210:
URL: https://github.com/apache/arrow-rs/pull/3210
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3210: add more integration test for parquet bloom filter round trip tests
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3210:
URL: https://github.com/apache/arrow-rs/pull/3210#issuecomment-1367370458
Benchmark runs are scheduled for baseline = 513d543cf99d0622661c2824d735d4f4bf17c0d3 and contender = 99a20dd872972096e54f26b33450c5958f33d2e5. 99a20dd872972096e54f26b33450c5958f33d2e5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7ff1e4fe58124445a4242279a156b8d8...7560185a1a3845aeb55762c8dc17d16c/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9489514855064d91ad13cce672386fd8...d41a95abc1364a6284672f3986a84d3a/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d255649d874f4066b0a34eadda5f0e79...1ceb4af7c7d44badac41aff71687305d/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a9c50823d3274429a7c376a5be1416dd...a91c712a8b714bbb9a02cb35e495c388/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #3210: add more integration test for parquet bloom filter round trip tests
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #3210:
URL: https://github.com/apache/arrow-rs/pull/3210#discussion_r1057658364
##########
parquet/pytest/test_parquet_integration.py:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import pyspark.sql
+import pandas as pd
+from tempfile import NamedTemporaryFile, TemporaryDirectory
+import subprocess
+import pathlib
+import pytest
+
+
+def create_data_and_spark_df(n):
+ spark = pyspark.sql.SparkSession.builder.getOrCreate()
+ spark.conf.set("parquet.bloom.filter.enabled", True)
+ spark.conf.set("parquet.bloom.filter.expected.ndv", 10)
+ spark.conf.set("parquet.bloom.filter.max.bytes", 32)
+ data = [(f"id-{i % 10}", f"name-{i%10}") for i in range(n)]
+ df = spark.createDataFrame(data, ["id", "name"]).repartition(1)
+ return data, df
+
+
+def create_data_and_pandas_df(n):
+ data = [(f"id-{i % 10}", f"name-{i%10}") for i in range(n)]
+ df = pd.DataFrame(data, columns=["id", "name"])
+ return data, df
+
+
+def get_expected_output(data):
+ expected = ["Row group #0", "=" * 80]
+ for v in data:
+ expected.append(f"Value {v[0]} is present in bloom filter")
+ for v in data:
+ expected.append(f"Value {v[1]} is absent in bloom filter")
+ expected = "\n".join(expected) + "\n"
+ return expected.encode("utf-8")
+
+
+def get_from_csv_cli_output(schema_file, output_file, csv_file):
+ args = [
+ "parquet-fromcsv",
+ "--schema",
+ schema_file,
+ "--enable-bloom-filter",
Review Comment:
This has now been resolved I believe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3210: WIP add more integration test for parquet bloom filter round trip tests
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3210:
URL: https://github.com/apache/arrow-rs/pull/3210#discussion_r1040791380
##########
parquet/pytest/test_parquet_integration.py:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import pyspark.sql
+import pandas as pd
+from tempfile import NamedTemporaryFile, TemporaryDirectory
+import subprocess
+import pathlib
+import pytest
+
+
+def create_data_and_spark_df(n):
+ spark = pyspark.sql.SparkSession.builder.getOrCreate()
+ spark.conf.set("parquet.bloom.filter.enabled", True)
+ spark.conf.set("parquet.bloom.filter.expected.ndv", 10)
+ spark.conf.set("parquet.bloom.filter.max.bytes", 32)
+ data = [(f"id-{i % 10}", f"name-{i%10}") for i in range(n)]
+ df = spark.createDataFrame(data, ["id", "name"]).repartition(1)
+ return data, df
+
+
+def create_data_and_pandas_df(n):
+ data = [(f"id-{i % 10}", f"name-{i%10}") for i in range(n)]
+ df = pd.DataFrame(data, columns=["id", "name"])
+ return data, df
+
+
+def get_expected_output(data):
+ expected = ["Row group #0", "=" * 80]
+ for v in data:
+ expected.append(f"Value {v[0]} is present in bloom filter")
+ for v in data:
+ expected.append(f"Value {v[1]} is absent in bloom filter")
+ expected = "\n".join(expected) + "\n"
+ return expected.encode("utf-8")
+
+
+def get_from_csv_cli_output(schema_file, output_file, csv_file):
+ args = [
+ "parquet-fromcsv",
+ "--schema",
+ schema_file,
+ "--enable-bloom-filter",
Review Comment:
Possibly https://github.com/apache/arrow-rs/issues/3275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Jimexist commented on a diff in pull request #3210: WIP add more integration test for parquet bloom filter round trip tests
Posted by GitBox <gi...@apache.org>.
Jimexist commented on code in PR #3210:
URL: https://github.com/apache/arrow-rs/pull/3210#discussion_r1033659334
##########
parquet/pytest/test_parquet_integration.py:
##########
@@ -0,0 +1,112 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import pyspark.sql
+import pandas as pd
+from tempfile import NamedTemporaryFile, TemporaryDirectory
+import subprocess
+import pathlib
+import pytest
+
+
+def create_data_and_spark_df(n):
+ spark = pyspark.sql.SparkSession.builder.getOrCreate()
+ spark.conf.set("parquet.bloom.filter.enabled", True)
+ spark.conf.set("parquet.bloom.filter.expected.ndv", 10)
+ spark.conf.set("parquet.bloom.filter.max.bytes", 32)
+ data = [(f"id-{i % 10}", f"name-{i%10}") for i in range(n)]
+ df = spark.createDataFrame(data, ["id", "name"]).repartition(1)
+ return data, df
+
+
+def create_data_and_pandas_df(n):
+ data = [(f"id-{i % 10}", f"name-{i%10}") for i in range(n)]
+ df = pd.DataFrame(data, columns=["id", "name"])
+ return data, df
+
+
+def get_expected_output(data):
+ expected = ["Row group #0", "=" * 80]
+ for v in data:
+ expected.append(f"Value {v[0]} is present in bloom filter")
+ for v in data:
+ expected.append(f"Value {v[1]} is absent in bloom filter")
+ expected = "\n".join(expected) + "\n"
+ return expected.encode("utf-8")
+
+
+def get_from_csv_cli_output(schema_file, output_file, csv_file):
+ args = [
+ "parquet-fromcsv",
+ "--schema",
+ schema_file,
+ "--enable-bloom-filter",
Review Comment:
@tustvold it seems that this didn't take effect during writing. any idea why?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #3210: add more integration test for parquet bloom filter round trip tests
Posted by GitBox <gi...@apache.org>.
alamb merged PR #3210:
URL: https://github.com/apache/arrow-rs/pull/3210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org