You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Disha Singh <di...@gmail.com> on 2016/01/21 02:11:40 UTC

Review Request 42580: Updated changelog :renaming of 'authenticate' to 'authenticate_frameworks' flag

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42580/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-4386
    https://issues.apache.org/jira/browse/MESOS-4386


Repository: mesos


Description
-------

Updated changelog :renaming of 'authenticate' to 'authenticate_frameworks' flag


Diffs
-----

  CHANGELOG 912a402 

Diff: https://reviews.apache.org/r/42580/diff/


Testing
-------

Not-required.Not a functional change.


Thanks,

Disha  Singh


Re: Review Request 42580: Updated changelog :renaming of 'authenticate' to 'authenticate_frameworks' flag

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42580/#review115551
-----------------------------------------------------------


Bad patch!

Reviews applied: [42580]

Failed command: ./support/apply-review.sh -n -r 42580

Error:
 2016-01-21 03:54:18 URL:https://reviews.apache.org/r/42580/diff/raw/ [467/467] -> "42580.patch" [1]
fatal: corrupt patch at line 14

- Mesos ReviewBot


On Jan. 21, 2016, 1:11 a.m., Disha  Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42580/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 1:11 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4386
>     https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated changelog :renaming of 'authenticate' to 'authenticate_frameworks' flag
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 912a402 
> 
> Diff: https://reviews.apache.org/r/42580/diff/
> 
> 
> Testing
> -------
> 
> Not-required.Not a functional change.
> 
> 
> Thanks,
> 
> Disha  Singh
> 
>


Re: Review Request 42580: Updated changelog :renaming of 'authenticate' to 'authenticate_frameworks' flag

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42580/#review115744
-----------------------------------------------------------



CHANGELOG (line 4)
<https://reviews.apache.org/r/42580/#comment176801>

    s/API Changes/Deprecations/
    
    This is not an API change yet.



CHANGELOG (line 5)
<https://reviews.apache.org/r/42580/#comment176803>

    * [MESOS-4386] - Deprecate 'authenticate' master flag in favor of 'authenticate_frameworks' flag.


- Vinod Kone


On Jan. 21, 2016, 1:11 a.m., Disha  Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42580/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2016, 1:11 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4386
>     https://issues.apache.org/jira/browse/MESOS-4386
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated changelog :renaming of 'authenticate' to 'authenticate_frameworks' flag
> 
> 
> Diffs
> -----
> 
>   CHANGELOG 912a402 
> 
> Diff: https://reviews.apache.org/r/42580/diff/
> 
> 
> Testing
> -------
> 
> Not-required.Not a functional change.
> 
> 
> Thanks,
> 
> Disha  Singh
> 
>