You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/10/15 16:51:31 UTC
Review Request 26749: Unit tests for heatmap metrics page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26749/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-7789
https://issues.apache.org/jira/browse/AMBARI-7789
Repository: ambari
Description
-------
Cover following scope with unit tests:
app/controllers/main/charts/heatmap_metrics/heatmap_metric.js
app/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun.js
Diffs
-----
ambari-web/app/assets/test/tests.js 1265411
ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric.js 839bb1b
ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun.js 1a15bb7
ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_test.js 40d886c
ambari-web/test/controllers/main/host/details_test.js f50d183
ambari-web/test/controllers/main/service/item_test.js 87dee7c
Diff: https://reviews.apache.org/r/26749/diff/
Testing
-------
4607 tests complete (8 seconds)
60 tests pending
Thanks,
Andrii Tkach
Re: Review Request 26749: Unit tests for heatmap metrics page
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26749/#review56709
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Жов. 15, 2014, 3:20 після полудня, Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26749/
> -----------------------------------------------------------
>
> (Updated Жов. 15, 2014, 3:20 після полудня)
>
>
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-7789
> https://issues.apache.org/jira/browse/AMBARI-7789
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cover following scope with unit tests:
> app/controllers/main/charts/heatmap_metrics/heatmap_metric.js
> app/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun.js
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js 1265411
> ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric.js 839bb1b
> ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun.js 1a15bb7
> ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_mapreduce_test.js PRE-CREATION
> ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun_test.js PRE-CREATION
> ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_test.js 40d886c
> ambari-web/test/controllers/main/host/details_test.js f50d183
> ambari-web/test/controllers/main/service/item_test.js 87dee7c
>
> Diff: https://reviews.apache.org/r/26749/diff/
>
>
> Testing
> -------
>
> 4607 tests complete (8 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 26749: Unit tests for heatmap metrics page
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26749/#review56711
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Окт. 15, 2014, 3:20 п.п., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26749/
> -----------------------------------------------------------
>
> (Updated Окт. 15, 2014, 3:20 п.п.)
>
>
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-7789
> https://issues.apache.org/jira/browse/AMBARI-7789
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Cover following scope with unit tests:
> app/controllers/main/charts/heatmap_metrics/heatmap_metric.js
> app/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun.js
>
>
> Diffs
> -----
>
> ambari-web/app/assets/test/tests.js 1265411
> ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric.js 839bb1b
> ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun.js 1a15bb7
> ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_mapreduce_test.js PRE-CREATION
> ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun_test.js PRE-CREATION
> ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_test.js 40d886c
> ambari-web/test/controllers/main/host/details_test.js f50d183
> ambari-web/test/controllers/main/service/item_test.js 87dee7c
>
> Diff: https://reviews.apache.org/r/26749/diff/
>
>
> Testing
> -------
>
> 4607 tests complete (8 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>
Re: Review Request 26749: Unit tests for heatmap metrics page
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26749/
-----------------------------------------------------------
(Updated Окт. 15, 2014, 3:20 п.п.)
Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
Bugs: AMBARI-7789
https://issues.apache.org/jira/browse/AMBARI-7789
Repository: ambari
Description
-------
Cover following scope with unit tests:
app/controllers/main/charts/heatmap_metrics/heatmap_metric.js
app/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun.js
Diffs (updated)
-----
ambari-web/app/assets/test/tests.js 1265411
ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric.js 839bb1b
ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun.js 1a15bb7
ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_mapreduce_test.js PRE-CREATION
ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun_test.js PRE-CREATION
ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_test.js 40d886c
ambari-web/test/controllers/main/host/details_test.js f50d183
ambari-web/test/controllers/main/service/item_test.js 87dee7c
Diff: https://reviews.apache.org/r/26749/diff/
Testing
-------
4607 tests complete (8 seconds)
60 tests pending
Thanks,
Andrii Tkach
Re: Review Request 26749: Unit tests for heatmap metrics page
Posted by Andrii Tkach <at...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26749/
-----------------------------------------------------------
(Updated Окт. 15, 2014, 2:53 п.п.)
Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
Bugs: AMBARI-7789
https://issues.apache.org/jira/browse/AMBARI-7789
Repository: ambari
Description
-------
Cover following scope with unit tests:
app/controllers/main/charts/heatmap_metrics/heatmap_metric.js
app/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun.js
Diffs
-----
ambari-web/app/assets/test/tests.js 1265411
ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric.js 839bb1b
ambari-web/app/controllers/main/charts/heatmap_metrics/heatmap_metric_processrun.js 1a15bb7
ambari-web/test/controllers/main/charts/heatmap_metrics/heatmap_metric_test.js 40d886c
ambari-web/test/controllers/main/host/details_test.js f50d183
ambari-web/test/controllers/main/service/item_test.js 87dee7c
Diff: https://reviews.apache.org/r/26749/diff/
Testing
-------
4607 tests complete (8 seconds)
60 tests pending
Thanks,
Andrii Tkach