[GitHub] [airflow] amoghrajesh commented on a diff in pull request #31328: Add missing priorityClassName to K8S worker pod template

["amoghrajesh (via GitHub)" <gi...@apache.org>]

amoghrajesh commented on code in PR #31328:
URL: https://github.com/apache/airflow/pull/31328#discussion_r1200251031


##########
chart/files/pod-template-file.kubernetes-helm-yaml:
##########
@@ -80,6 +80,9 @@ spec:
     {{- if .Values.workers.extraContainers }}
       {{- toYaml .Values.workers.extraContainers | nindent 4 }}
     {{- end }}
+  {{- if .Values.workers.priorityClassName }}
+  priorityClassName: {{ .Values.workers.priorityClassName }}
+  {{- end }}

Review Comment:
   I think we should also have a priority class definition in the code base. Otherwise users will be expected to create their own priorityclasses and then only run this part.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org