You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/10/17 07:26:41 UTC
Review Request 26861: Schedule docker containers for removal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26861/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Instead of removing docker containers right after reap, schedule it to be removed later.
Diffs
-----
src/slave/containerizer/docker.cpp 9a29489
Diff: https://reviews.apache.org/r/26861/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26861: Schedule docker containers for removal
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26861/#review59391
-----------------------------------------------------------
Ship it!
src/slave/constants.hpp
<https://reviews.apache.org/r/26861/#comment100657>
Since you ultimatly call Docker::rm, let's s/cleanup/remove/g.
- Benjamin Hindman
On Oct. 29, 2014, 12:02 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26861/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2014, 12:02 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Instead of removing docker containers right after reap, schedule it to be removed later.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp 9030871
> src/slave/constants.cpp e1da5c0
> src/slave/containerizer/docker.cpp 9a29489
> src/slave/flags.hpp f7a8cde
>
> Diff: https://reviews.apache.org/r/26861/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26861: Schedule docker containers for removal
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26861/
-----------------------------------------------------------
(Updated Oct. 31, 2014, 11:36 p.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Instead of removing docker containers right after reap, schedule it to be removed later.
Diffs (updated)
-----
src/slave/constants.hpp 9030871
src/slave/constants.cpp e1da5c0
src/slave/containerizer/docker.cpp d6617a9
src/slave/flags.hpp f7a8cde
Diff: https://reviews.apache.org/r/26861/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26861: Schedule docker containers for removal
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26861/
-----------------------------------------------------------
(Updated Oct. 29, 2014, 12:02 a.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Instead of removing docker containers right after reap, schedule it to be removed later.
Diffs (updated)
-----
src/slave/constants.hpp 9030871
src/slave/constants.cpp e1da5c0
src/slave/containerizer/docker.cpp 9a29489
src/slave/flags.hpp f7a8cde
Diff: https://reviews.apache.org/r/26861/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26861: Schedule docker containers for removal
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26861/
-----------------------------------------------------------
(Updated Oct. 21, 2014, 1:21 a.m.)
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Instead of removing docker containers right after reap, schedule it to be removed later.
Diffs (updated)
-----
src/slave/constants.hpp 9030871
src/slave/constants.cpp e1da5c0
src/slave/containerizer/docker.cpp 9a29489
src/slave/flags.hpp 03c62a2
Diff: https://reviews.apache.org/r/26861/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26861: Schedule docker containers for removal
Posted by Timothy Chen <tn...@apache.org>.
> On Oct. 20, 2014, 4:35 a.m., Benjamin Hindman wrote:
> > src/slave/containerizer/docker.cpp, lines 1539-1548
> > <https://reviews.apache.org/r/26861/diff/2/?file=724760#file724760line1539>
> >
> > Does this change belong here? I see it's reverted in https://reviews.apache.org/r/26862?
yes, It is part of the scheduling remove patch. Although later I changed it to call kill always, but still never remove it until gc runs.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26861/#review57309
-----------------------------------------------------------
On Oct. 17, 2014, 7:32 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26861/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 7:32 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Instead of removing docker containers right after reap, schedule it to be removed later.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp 9030871
> src/slave/constants.cpp e1da5c0
> src/slave/containerizer/docker.cpp 9a29489
> src/slave/flags.hpp 03c62a2
>
> Diff: https://reviews.apache.org/r/26861/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26861: Schedule docker containers for removal
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26861/#review57309
-----------------------------------------------------------
src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/26861/#comment97986>
Does this change belong here? I see it's reverted in https://reviews.apache.org/r/26862?
- Benjamin Hindman
On Oct. 17, 2014, 7:32 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26861/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 7:32 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Instead of removing docker containers right after reap, schedule it to be removed later.
>
>
> Diffs
> -----
>
> src/slave/constants.hpp 9030871
> src/slave/constants.cpp e1da5c0
> src/slave/containerizer/docker.cpp 9a29489
> src/slave/flags.hpp 03c62a2
>
> Diff: https://reviews.apache.org/r/26861/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 26861: Schedule docker containers for removal
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26861/
-----------------------------------------------------------
(Updated Oct. 17, 2014, 7:32 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Added new docker flag for removal duration
Repository: mesos-git
Description
-------
Instead of removing docker containers right after reap, schedule it to be removed later.
Diffs (updated)
-----
src/slave/constants.hpp 9030871
src/slave/constants.cpp e1da5c0
src/slave/containerizer/docker.cpp 9a29489
src/slave/flags.hpp 03c62a2
Diff: https://reviews.apache.org/r/26861/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 26861: Schedule docker containers for removal
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26861/#review57112
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26610, 26861]
All tests passed.
- Mesos ReviewBot
On Oct. 17, 2014, 5:26 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26861/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 5:26 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Instead of removing docker containers right after reap, schedule it to be removed later.
>
>
> Diffs
> -----
>
> src/slave/containerizer/docker.cpp 9a29489
>
> Diff: https://reviews.apache.org/r/26861/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>