[GitHub] [lucene] mayya-sharipova commented on a change in pull request #331: LUCENE-10126: Re-introduce chunk scoring logic in tests

[GitBox <gi...@apache.org>]

mayya-sharipova commented on a change in pull request #331:
URL: https://github.com/apache/lucene/pull/331#discussion_r719451602



##########
File path: lucene/test-framework/src/java/org/apache/lucene/search/AssertingScorable.java
##########
@@ -45,13 +45,41 @@ public static Scorable wrap(Scorable in) {
     if (in instanceof AssertingScorable) {
       return in;
     }
-    return new AssertingScorable(in);
+    // If `in` is Scorer, we need to wrap it as a Scorer instead of Scorable because
+    // NumericComparator uses the iterator cost of a Scorer in sort optimization.

Review comment:
       Not to be addressed by this PR, but we also have an [issue](https://issues.apache.org/jira/browse/LUCENE-9352) to add cost to `Scorable`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org